You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Adam Hunyadi (Jira)" <ji...@apache.org> on 2020/09/18 11:11:00 UTC

[jira] [Updated] (MINIFICPP-1306) Replace header guards with #pragma once

     [ https://issues.apache.org/jira/browse/MINIFICPP-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Adam Hunyadi updated MINIFICPP-1306:
------------------------------------
    Labels: MiNiFi-CPP-Hygiene easyfix  (was: MiNiFi-CPP-Hygiene)

> Replace header guards with #pragma once
> ---------------------------------------
>
>                 Key: MINIFICPP-1306
>                 URL: https://issues.apache.org/jira/browse/MINIFICPP-1306
>             Project: Apache NiFi MiNiFi C++
>          Issue Type: Task
>    Affects Versions: 0.7.0
>            Reporter: Adam Hunyadi
>            Priority: Minor
>              Labels: MiNiFi-CPP-Hygiene, easyfix
>             Fix For: 1.0.0
>
>
> *Background:*
> The team decided to replace header guards with {{{color:#403294}{{#pragma once}}{color}}} once. It is not standardized, but all the compilers we support have it, and we already have it scattered in our headers, so we can consider this update safe.
> *Proposal:*
> It should be easy to replace the header guards based on the linter recommendations. Once we have all the linter warnings enabled, [[this function from cpplint]|https://github.com/cpplint/cpplint/blob/1.5.3/cpplint.py#L2286] can be used to find the header guard string and replaced in the {{{color:#403294}{{#ifndef}}{color}}} and {{{color:#403294}{{#define}}{color}}} and matching {{{color:#403294}{{#endif}}{color}}}.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)