You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by "jira-importer (via GitHub)" <gi...@apache.org> on 2025/01/21 13:10:06 UTC
[I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
jira-importer opened a new issue, #542:
URL: https://github.com/apache/curator/issues/542
<p>PathChildrenCache currently takes an Executor, but only to fire off a Runnable that does a blocking while loop waiting for work. This means that you must have one thread per PathChildrenCache, which is not that great.</p>
<p>PathChildrenCache should just use the Executor's work queuing mechanism to enqueue work items instead of maintaining its own work queue mechanism.</p>
---
<details><summary><i>Originally reported by <a title="Eric Tschetter" href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>, imported from: <a href="https://issues.apache.org/jira/browse/CURATOR-21" target="_blank">PathChildrenCache consumes an entire thread all the time no matter what</a></i></summary>
<i><ul>
<li><b>assignee</b>: <a title="Jordan Zimmerman" href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>
<li><b>status</b>: Resolved
<li><b>priority</b>: Major
<li><b>resolution</b>: Fixed
<li><b>resolved</b>: 2013-05-06T19:57:56+01:00
<li><b>imported</b>: 2025-01-21
</ul></i>
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693568
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>LGTM</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693536
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i>
<p>In the modified offerOperation(), why single out RefreshOperations for herding check? We can have a similar behavior as before with an <tt>operations</tt> set. Also, this eliminates the need to examine the internals of the operation.</p>
<p>E.g. <a href="https://gist.github.com/Randgalt/5519586" class="external-link" target="_blank" rel="nofollow noopener">https://gist.github.com/Randgalt/5519586</a></p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693552
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i>
<p>Please pull and checkout branch <a href="https://issues.apache.org/jira/browse/CURATOR-21" title="PathChildrenCache consumes an entire thread all the time no matter what" class="issue-link" data-issue-key="CURATOR-21"><del>CURATOR-21</del></a>.</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693522
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i>
<p>Can you re-make the patches against the Apache source? </p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693530
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>Attaching another patch to fix a slight bug with the changes introduced here.</p>
<p>Allowing the executor to queue up tasks has introduced a race condition in which. Specifically, if the PathChildrenCache is set to watch for data changes, after the PathChildrenCache has been closed the dataWatcher will stay registered on the various paths ('cause ZK is awesome like that) and, when changes happen to those paths, the watcher will fire and try to submit Runnables to the closed ExecutorService. This results in RejectedExecutionExceptions showing up in the logs, there is actually nothing functionally wrong with this other than that it scares people who don't know what is going on.</p>
<p>This patch fixes it so that it will not generate those exceptions anymore.</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693573
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i>
<p>Now available in branch 2.0.1-incubating</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693544
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=randgalt">randgalt</a>:</i>
<p>I'm now wondering if the collation of operations is no longer correct. In the previous implementation, pending operations that were exactly the same were coalesced. In this implementation, a refresh that is to be queued while a refresh is in process gets dropped. I need to think about this more but I believe it's incorrect.</p>
<p>I updated the gist to reflect what I think is more like the previous implementation.</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693510
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>Attaching another patch of some documentation changes that I believe help clarify the expectations around which events listeners should particularly care about.</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693558
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>Ah, yes, I was thinking that the refresh operation made it up to date as of the end of the operation, but it makes sense that it's only up-to-date as of the beginning of the operation, so it does need to queue up other refreshes that come while it is operating.</p>
<p>I'll check out the branch</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693528
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>Patches on apache code base</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [CURATOR-21] PathChildrenCache consumes an entire thread all the time no matter what [curator]
Posted by "jira-importer (via GitHub)" <gi...@apache.org>.
jira-importer commented on issue #542:
URL: https://github.com/apache/curator/issues/542#issuecomment-2604693519
<i><a href="https://issues.apache.org/jira/secure/ViewProfile.jspa?name=cheddar">cheddar</a>:</i>
<p>upload the right patch file this time...</p>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org