You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/11/08 02:38:46 UTC

[GitHub] [spark] sarutak commented on a change in pull request #34503: [SPARK-37225][SQL] Support reading and writing ANSI intervals from/to Avro datasources

sarutak commented on a change in pull request #34503:
URL: https://github.com/apache/spark/pull/34503#discussion_r744370280



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/DataSource.scala
##########
@@ -587,7 +587,8 @@ case class DataSource(
   private def disallowWritingIntervals(
       dataTypes: Seq[DataType],
       forbidAnsiIntervals: Boolean): Unit = {
-    val isWriteAllowedSource = writeAllowedSources(providingClass)
+    val isWriteAllowedSource = writeAllowedSources(providingClass) ||
+      providingClass.getCanonicalName == "org.apache.spark.sql.avro.AvroFileFormat"

Review comment:
       I agree. will you remove this check within  this PR?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org