You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-dev@xmlgraphics.apache.org by Jeremias Maerki <de...@greenmail.ch> on 2004/10/01 15:19:46 UTC

Re: cvs commit: xml-fop/src/java/org/apache/fop/render/rtf TableAttributesConverter.java

Finn, it seems to me that you probably forgot the check in all your
changes. FOP doesn't compile ATM. The method makeBorder is missing.

On 01.10.2004 11:46:36 bckfnn wrote:
> bckfnn      2004/10/01 02:46:36
> 
>   Modified:    src/java/org/apache/fop/render/rtf
>                         TableAttributesConverter.java
>   Log:
>   Simplified the handling of length attributes.
>   Attempt at setting borders correctly.
>   
>   Revision  Changes    Path
>   1.16      +49 -140   xml-fop/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java
>   
>   Index: TableAttributesConverter.java
>   ===================================================================
>   RCS file: /home/cvs/xml-fop/src/java/org/apache/fop/render/rtf/TableAttributesConverter.java,v
>   retrieving revision 1.15
>   retrieving revision 1.16
>   diff -u -r1.15 -r1.16
>   --- TableAttributesConverter.java	23 May 2004 17:00:00 -0000	1.15
>   +++ TableAttributesConverter.java	1 Oct 2004 09:46:36 -0000	1.16
<snip/>
>   +        BorderAttributesConverter.makeBorder(propList, attrib, ITableAttributes.CELL_BORDER_TOP,
>   +                Constants.PR_BORDER_TOP_COLOR, 
>   +                Constants.PR_BORDER_TOP_STYLE, 
>   +                Constants.PR_BORDER_TOP_WIDTH);
>   +        BorderAttributesConverter.makeBorder(propList, attrib, ITableAttributes.CELL_BORDER_BOTTOM,
>   +                Constants.PR_BORDER_BOTTOM_COLOR, 
>   +                Constants.PR_BORDER_BOTTOM_STYLE, 
>   +                Constants.PR_BORDER_BOTTOM_WIDTH);
>   +        BorderAttributesConverter.makeBorder(propList, attrib, ITableAttributes.CELL_BORDER_LEFT,
>   +                Constants.PR_BORDER_LEFT_COLOR, 
>   +                Constants.PR_BORDER_LEFT_STYLE, 
>   +                Constants.PR_BORDER_LEFT_WIDTH);
>   +        BorderAttributesConverter.makeBorder(propList, attrib,  ITableAttributes.CELL_BORDER_RIGHT,
>   +                Constants.PR_BORDER_RIGHT_COLOR, 
>   +                Constants.PR_BORDER_RIGHT_STYLE, 
>   +                Constants.PR_BORDER_RIGHT_WIDTH);


Jeremias Maerki


Re: cvs commit: xml-fop/src/java/org/apache/fop/render/rtf TableAttributesConverter.java

Posted by Finn Bock <bc...@worldonline.dk>.
[Jeremias Maerki]

> Finn, it seems to me that you probably forgot the check in all your
> changes. FOP doesn't compile ATM. The method makeBorder is missing.

Yes, I forgot. I'm sorry for the inconvenience.

Glen, Thank You for temporarily fixing my mistake.

regards,
finn