[GitHub] [maven] gnodet opened a new pull request, #817: Simplify build / consumer

[GitBox <gi...@apache.org>]

gnodet opened a new pull request, #817:
URL: https://github.com/apache/maven/pull/817

   This commit optimizes and simplifies the build/consumer feature.
   For the build -> raw transformation, a context containing all raw models from the reactor is needed. The relative path version mapping will infer the version of the parent while the dependency key version mapping will infer the version of a dependency, but in both cases, all the raw models from the reactor have to be parsed in order to actually know those versions.
   This actually forces a multi-step loading of the projects, first to read file models, then then to re-read them with the known context to obtain raw models.  This is uneffective and actually makes implementing the build -> raw transformation quite complicated, using filters at the xml level.
   This commit simply changes the transformation from the xml level to the model level : the transformers now modify the parsed Model directly.
   For the raw -> consumer transformation, this commit currently keeps the transformation at the xml level, but it could be changed too.  In addition, the maven-resolver transformer api has been deprecated (https://github.com/apache/maven-resolver/commit/1c79c4f8b6573e9693f4ae61c14bff17755aa32d), so we'd better find another way to compute the consumer model.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet closed pull request #817: Simplify build / consumer

[GitBox <gi...@apache.org>]

gnodet closed pull request #817: Simplify build / consumer
URL: https://github.com/apache/maven/pull/817


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [maven] gnodet commented on pull request #817: Simplify build / consumer

[GitBox <gi...@apache.org>]

gnodet commented on PR #817:
URL: https://github.com/apache/maven/pull/817#issuecomment-1270047431

   The whole PR is based on a wrong assumption, so closing it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org