You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by GitBox <gi...@apache.org> on 2023/01/09 14:17:49 UTC
[GitHub] [sling-org-apache-sling-repoinit-parser] kwin commented on a diff in pull request #28: SLING-10281 add "ensure principal ACL" with stricter semantics
kwin commented on code in PR #28:
URL: https://github.com/apache/sling-org-apache-sling-repoinit-parser/pull/28#discussion_r1064688412
##########
src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java:
##########
@@ -27,7 +27,9 @@
/** Set ACL statement that groups a set of AclLines
* that all refer to the same set of principals.
+ * @deprecated Use {@link EnsureAclPrincipalBased} based with stricter semantics
*/
+@Deprecated
@ProviderType
public class SetAclPrincipalBased extends AclGroupBase {
Review Comment:
Ok, let us separate the deprecation announcement into a separate PR. I am not convinced TBH that INFO is the right level for deprecation :-)
##########
src/main/java/org/apache/sling/repoinit/parser/operations/SetAclPrincipalBased.java:
##########
@@ -27,7 +27,9 @@
/** Set ACL statement that groups a set of AclLines
* that all refer to the same set of principals.
+ * @deprecated Use {@link EnsureAclPrincipalBased} based with stricter semantics
*/
+@Deprecated
@ProviderType
public class SetAclPrincipalBased extends AclGroupBase {
Review Comment:
Ok, let us separate the deprecation logging into a separate PR. I am not convinced TBH that INFO is the right level for deprecation :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org