[GitHub] [sling-org-apache-sling-scripting-sightly] Buuhuu commented on pull request #12: SLING-10654: add support for ICU MessageFormat

[GitBox <gi...@apache.org>]

Buuhuu commented on pull request #12:
URL: https://github.com/apache/sling-org-apache-sling-scripting-sightly/pull/12#issuecomment-887443088


   > There's one thing which I don't like that much, namely that icu4j doesn't version the exported packages, which could lead to runtime errors in the future. Any idea what we could do about that?
   
   I agree, however the API used in this PR is actually the [Java JDK API](https://docs.oracle.com/javase/8/docs/api/java/text/MessageFormat.html). The risk, that this causes problems with any additional use of different APIs in the future exists, but I don't expect any runtime issues by different bundle/package versions right now. The outputs the format generates may still change, depending on the cldr version for example (see the discussion about the date-time formats). 
   
   Alternative options would be to wrap icu4j into a sling bundle (maybe even a fragment of sling i18n, i don't know) and track package versions ourself, or convince the icu4j maintainers to properly annotate the exported packages. The later sounds reasonable but also requires the icu4j maintainers to deal with osgi semantic versioning. I can take this up but I also expect the package major versions to change often as many classes are ConsumerTypes and the changes made, may often be binary incompatible. 
   
   For now I think we are good, as long as we keep in mind not to introduce any problematic API usage. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@sling.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org