You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@twopensource.com> on 2014/11/21 00:05:55 UTC
Review Request 28302: Fail builds if not compiled with Gradle 2.2
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/
-----------------------------------------------------------
Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
Bugs: AURORA-941
https://issues.apache.org/jira/browse/AURORA-941
Repository: aurora
Description
-------
The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
Diffs
-----
buildSrc/build.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/28302/diff/
Testing
-------
Incorrect version:
````
$ ~/Downloads/gradle-2.1/bin/gradle clean test
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
* What went wrong:
A problem occurred evaluating root project 'buildSrc'.
> Building is only supported with gradle version 2.2.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 0.952 secs
````
Correct version:
````
$ ./gradlew clean test
:buildSrc:clean
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift UP-TO-DATE
:checkPython
:generateSources
:compileGeneratedJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJava
Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:compileTestJava
:processTestResources
:testClasses
:test
objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
:jacocoTestReport
Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
BUILD SUCCESSFUL
Total time: 1 mins 28.786 secs
````
Thanks,
Zameer Manji
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62573
-----------------------------------------------------------
Ship it!
Ship It!
- Joshua Cohen
On Nov. 21, 2014, 5:20 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:20 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> buildSrc/build.gradle PRE-CREATION
> buildSrc/gradle.properties PRE-CREATION
> settings.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62638
-----------------------------------------------------------
Ship it!
This is now on master
```
$ git log -1 origin/master --abbrev-commit
commit f43700c
Author: Zameer Manji <zm...@twopensource.com>
Date: Fri Nov 21 12:55:24 2014 -0800
Fail builds if not compiled with Gradle 2.2
Bugs closed: AURORA-941
Reviewed at https://reviews.apache.org/r/28302/
```
- Bill Farner
On Nov. 21, 2014, 5:20 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:20 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> buildSrc/build.gradle PRE-CREATION
> buildSrc/gradle.properties PRE-CREATION
> settings.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62589
-----------------------------------------------------------
Bill, since you were the last commiter to give a shipit can you please commit this?
- Zameer Manji
On Nov. 20, 2014, 9:20 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:20 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> buildSrc/build.gradle PRE-CREATION
> buildSrc/gradle.properties PRE-CREATION
> settings.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62529
-----------------------------------------------------------
Ship it!
Master (ada97bd) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 21, 2014, 5:20 a.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 21, 2014, 5:20 a.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> buildSrc/build.gradle PRE-CREATION
> buildSrc/gradle.properties PRE-CREATION
> settings.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Zameer Manji <zm...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/
-----------------------------------------------------------
(Updated Nov. 20, 2014, 9:20 p.m.)
Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
Changes
-------
Remove duplication of gradle version.
Bugs: AURORA-941
https://issues.apache.org/jira/browse/AURORA-941
Repository: aurora
Description
-------
The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
Diffs (updated)
-----
build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
buildSrc/build.gradle PRE-CREATION
buildSrc/gradle.properties PRE-CREATION
settings.gradle PRE-CREATION
Diff: https://reviews.apache.org/r/28302/diff/
Testing
-------
Incorrect version:
````
$ ~/Downloads/gradle-2.1/bin/gradle clean test
FAILURE: Build failed with an exception.
* Where:
Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
* What went wrong:
A problem occurred evaluating root project 'buildSrc'.
> Building is only supported with gradle version 2.2.
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 0.952 secs
````
Correct version:
````
$ ./gradlew clean test
:buildSrc:clean
:buildSrc:compileJava UP-TO-DATE
:buildSrc:compileGroovy
:buildSrc:processResources UP-TO-DATE
:buildSrc:classes
:buildSrc:jar
:buildSrc:assemble
:buildSrc:compileTestJava UP-TO-DATE
:buildSrc:compileTestGroovy UP-TO-DATE
:buildSrc:processTestResources UP-TO-DATE
:buildSrc:testClasses UP-TO-DATE
:buildSrc:test UP-TO-DATE
:buildSrc:check UP-TO-DATE
:buildSrc:build
:clean
:bootstrapThrift UP-TO-DATE
:checkPython
:generateSources
:compileGeneratedJava
Note: Some input files use unchecked or unsafe operations.
Note: Recompile with -Xlint:unchecked for details.
:processGeneratedResources UP-TO-DATE
:generatedClasses
:compileJava
Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
:processResources
:classes
:compileTestJava
:processTestResources
:testClasses
:test
objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
:jacocoTestReport
Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
:analyzeReport
Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
BUILD SUCCESSFUL
Total time: 1 mins 28.786 secs
````
Thanks,
Zameer Manji
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Bill Farner <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62507
-----------------------------------------------------------
Ship it!
buildSrc/build.gradle
<https://reviews.apache.org/r/28302/#comment104538>
s/ / /
- Bill Farner
On Nov. 20, 2014, 11:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 11:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Kevin Sweeney <ke...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62482
-----------------------------------------------------------
Ship it!
Ship It!
- Kevin Sweeney
On Nov. 20, 2014, 3:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 3:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Zameer Manji <zm...@twopensource.com>.
> On Nov. 20, 2014, 3:09 p.m., Joshua Cohen wrote:
> > Why do we have to do this in buildSrc/build.gradle and not the root build.gradle?
buildSrc is special and run before the build.gradle: http://www.gradle.org/docs/current/userguide/organizing_build_logic.html#sec:build_sources
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62453
-----------------------------------------------------------
On Nov. 20, 2014, 3:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 3:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Zameer Manji <zm...@twopensource.com>.
> On Nov. 20, 2014, 3:09 p.m., Joshua Cohen wrote:
> > Why do we have to do this in buildSrc/build.gradle and not the root build.gradle?
>
> Zameer Manji wrote:
> buildSrc is special and run before the build.gradle: http://www.gradle.org/docs/current/userguide/organizing_build_logic.html#sec:build_sources
>
> Joshua Cohen wrote:
> To expand, my concern is that now when we bump gradle versions we'll have to update it in two places (we define the version for the wrapper task in the root build.gradle, it'd be nicer if we could have a single GRADLE_VERSION constant used by both).
Although it isn't the cleanest, I have now achieved this.
- Zameer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62453
-----------------------------------------------------------
On Nov. 20, 2014, 9:20 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 9:20 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> build.gradle 3237f8dfa3e7d4249a388042dba840a939d513b3
> buildSrc/build.gradle PRE-CREATION
> buildSrc/gradle.properties PRE-CREATION
> settings.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Joshua Cohen <jc...@twopensource.com>.
> On Nov. 20, 2014, 11:09 p.m., Joshua Cohen wrote:
> > Why do we have to do this in buildSrc/build.gradle and not the root build.gradle?
>
> Zameer Manji wrote:
> buildSrc is special and run before the build.gradle: http://www.gradle.org/docs/current/userguide/organizing_build_logic.html#sec:build_sources
To expand, my concern is that now when we bump gradle versions we'll have to update it in two places (we define the version for the wrapper task in the root build.gradle, it'd be nicer if we could have a single GRADLE_VERSION constant used by both).
- Joshua
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62453
-----------------------------------------------------------
On Nov. 20, 2014, 11:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 11:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Joshua Cohen <jc...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62453
-----------------------------------------------------------
Why do we have to do this in buildSrc/build.gradle and not the root build.gradle?
- Joshua Cohen
On Nov. 20, 2014, 11:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 11:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 28302: Fail builds if not compiled with Gradle 2.2
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/28302/#review62464
-----------------------------------------------------------
Ship it!
Master (ada97bd) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On Nov. 20, 2014, 11:05 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/28302/
> -----------------------------------------------------------
>
> (Updated Nov. 20, 2014, 11:05 p.m.)
>
>
> Review request for Aurora, Joshua Cohen, Kevin Sweeney, and Bill Farner.
>
>
> Bugs: AURORA-941
> https://issues.apache.org/jira/browse/AURORA-941
>
>
> Repository: aurora
>
>
> Description
> -------
>
> The source tarball does not have gradlew and therefore is there is no way to ensure the code will be built with the correct version of Gradle. This patch fails the build if we are not building with the correct version of Gradle. This provdes a much nicer error message to the user.
>
>
> Diffs
> -----
>
> buildSrc/build.gradle PRE-CREATION
>
> Diff: https://reviews.apache.org/r/28302/diff/
>
>
> Testing
> -------
>
> Incorrect version:
> ````
> $ ~/Downloads/gradle-2.1/bin/gradle clean test
>
> FAILURE: Build failed with an exception.
>
> * Where:
> Build file '/Users/zmanji/workspace/aurora/buildSrc/build.gradle' line: 2
>
> * What went wrong:
> A problem occurred evaluating root project 'buildSrc'.
> > Building is only supported with gradle version 2.2.
>
> * Try:
> Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
>
> BUILD FAILED
>
> Total time: 0.952 secs
> ````
>
> Correct version:
> ````
> $ ./gradlew clean test
> :buildSrc:clean
> :buildSrc:compileJava UP-TO-DATE
> :buildSrc:compileGroovy
> :buildSrc:processResources UP-TO-DATE
> :buildSrc:classes
> :buildSrc:jar
> :buildSrc:assemble
> :buildSrc:compileTestJava UP-TO-DATE
> :buildSrc:compileTestGroovy UP-TO-DATE
> :buildSrc:processTestResources UP-TO-DATE
> :buildSrc:testClasses UP-TO-DATE
> :buildSrc:test UP-TO-DATE
> :buildSrc:check UP-TO-DATE
> :buildSrc:build
> :clean
> :bootstrapThrift UP-TO-DATE
> :checkPython
> :generateSources
> :compileGeneratedJava
> Note: Some input files use unchecked or unsafe operations.
> Note: Recompile with -Xlint:unchecked for details.
> :processGeneratedResources UP-TO-DATE
> :generatedClasses
> :compileJava
> Note: Writing file:/Users/zmanji/workspace/aurora/dist/classes/main/com/twitter/common/args/apt/cmdline.arg.info.txt.2
> :processResources
> :classes
> :compileTestJava
> :processTestResources
> :testClasses
> :test
> objc[67076]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67077]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67078]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> objc[67079]: Class JavaLaunchHelper is implemented in both /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/bin/java and /Library/Java/JavaVirtualMachines/jdk1.7.0_60.jdk/Contents/Home/jre/lib/libinstrument.dylib. One of the two will be used. Which one is undefined.
> :jacocoTestReport
> Coverage report generated: file:///Users/zmanji/workspace/aurora/dist/reports/jacoco/test/html/index.html
> :analyzeReport
> Instruction coverage of 0.89 exceeds min instruction coverage of 0.88 by more than 0.005, please raise the threshold!
> Branch coverage of 0.84 exceeds min instruction coverage of 0.83 by more than 0.005, please raise the threshold!
>
> BUILD SUCCESSFUL
>
> Total time: 1 mins 28.786 secs
> ````
>
>
> Thanks,
>
> Zameer Manji
>
>