You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/04/20 16:28:02 UTC
[GitHub] [airflow] mik-laj commented on a change in pull request #5139:
[AIRFLOW-4360][WIP] Add performance metrics for Webserver UI.
mik-laj commented on a change in pull request #5139: [AIRFLOW-4360][WIP] Add performance metrics for Webserver UI.
URL: https://github.com/apache/airflow/pull/5139#discussion_r277139522
##########
File path: airflow/www/views.py
##########
@@ -531,7 +534,8 @@ def get_logs_with_metadata(self, session=None):
execution_date))
response = jsonify({'error': error_message})
response.status_code = 400
-
+ # Bad format, don't count as fetch failure.
+ Stats.decr('webserver.get_logs_with_metadata.failures')
Review comment:
```suggestion
Stats.incr('webserver.get_logs_with_metadata.failures')
```
Why is this metric decreased?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services