You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tinkerpop.apache.org by ok...@apache.org on 2017/07/14 14:58:06 UTC

[3/3] tinkerpop git commit: Merge branch 'TINKERPOP-880'

Merge branch 'TINKERPOP-880'


Project: http://git-wip-us.apache.org/repos/asf/tinkerpop/repo
Commit: http://git-wip-us.apache.org/repos/asf/tinkerpop/commit/489533ff
Tree: http://git-wip-us.apache.org/repos/asf/tinkerpop/tree/489533ff
Diff: http://git-wip-us.apache.org/repos/asf/tinkerpop/diff/489533ff

Branch: refs/heads/master
Commit: 489533ff34a0cb24ded0317d8aaedf4c9a4c9dcf
Parents: caa5e5b 99d38d4
Author: Marko A. Rodriguez <ok...@gmail.com>
Authored: Fri Jul 14 08:57:58 2017 -0600
Committer: Marko A. Rodriguez <ok...@gmail.com>
Committed: Fri Jul 14 08:57:58 2017 -0600

----------------------------------------------------------------------
 CHANGELOG.asciidoc                              |   1 +
 docs/src/upgrade/release-3.3.x.asciidoc         |   5 +-
 .../traversal/dsl/graph/GraphTraversal.java     |  23 --
 .../gremlin/process/traversal/dsl/graph/__.java |  16 --
 .../traversal/step/map/GroupStepV3d0.java       | 172 --------------
 .../sideEffect/GroupSideEffectStepV3d0.java     | 151 ------------
 .../process/traversal/util/TraversalHelper.java |  14 --
 .../gremlin/structure/io/gryo/GryoVersion.java  |   5 +-
 .../sideEffect/GroupSideEffectStepV3d0Test.java |  47 ----
 .../gremlin_python/process/graph_traversal.py   |  12 -
 .../gremlin/process/ProcessComputerSuite.java   |   2 -
 .../gremlin/process/ProcessStandardSuite.java   |   2 -
 .../step/sideEffect/GroupTestV3d0.java          | 236 -------------------
 .../gremlin/hadoop/structure/HadoopGraph.java   |  10 -
 .../structure/TinkerGraphPlayTest.java          |  41 ----
 15 files changed, 7 insertions(+), 730 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/CHANGELOG.asciidoc
----------------------------------------------------------------------
diff --cc CHANGELOG.asciidoc
index b546093,c285e53..e92a157
--- a/CHANGELOG.asciidoc
+++ b/CHANGELOG.asciidoc
@@@ -26,26 -26,7 +26,27 @@@ image::https://raw.githubusercontent.co
  TinkerPop 3.3.0 (Release Date: NOT OFFICIALLY RELEASED YET)
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  
 +* Removed previously deprecated `DetachedEdge(Object,String,Map,Pair,Pair)` constructor.
 +* Removed previously deprecated `Bindings` constructor. It is now a private constructor.
 +* Removed previously deprecated `TraversalSource.withBindings()`.
 +* Removed previously deprecated `GraphTraversal.sack(BiFunction,String)`.
 +* `TraversalMetrics` and `Metrics` Gryo 1.0 formats changed given internal changes to their implementations.
 +* Made `TraversalMetrics` safe to write to from multiple threads.
 +* Removed previously deprecated `TraversalSideEffects` methods.
 +* Removed previously deprecated `finalization.LazyBarrierStrategy` (moved to `optimization.LazyBarrierStrategy`).
 +* Removed previously deprecated `Constants` in Hadoop.
 +* Removed previously deprecated `VertexComputing.generateComputer(Graph)`.
 +* Established the Gryo 3.0 format.
 +* `GryoVersion` now includes a default `ClassResolver` to supply to the `GryoMapper`.
 +* `GryoClassResolver` renamed to `GryoClassResolverV1d0` which has an abstract class that for providers to extend in `AbstractGryoClassResolver`.
 +* Removed previously deprecated `Order` enums of `keyIncr`, `keyDecr`, `valueIncr`, and `valueDecr.`
 +* Removed previously deprecated `GraphTraversal.mapKeys()` step.
 +* Removed previously deprecated `GraphTraversal.mapValues()` step.
 +* Removed previously deprecated `GraphTraversal#addV(Object...)`.
 +* Removed previously deprecated `GraphTraversal#addE(Direction, String, String, Object...)`.
 +* Removed previously deprecated `GraphTraversal#addOutE(String, String, Object...)`.
 +* Removed previously deprecated `GraphTraversal#addInV(String, String, Object...)`.
+ * Removed previously deprecated `GraphTraversal.groupV3d0()` and respective `GroupSideEffectStepV3d0` and `GroupStepV3d0`.
  * Removed previously deprecated `TraversalSource.Builder` class.
  * Removed previously deprecated `ConnectiveP`, `AndP`, `OrP` constructors.
  * Removed previously deprecated `TraversalScriptFunction` class.

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/docs/src/upgrade/release-3.3.x.asciidoc
----------------------------------------------------------------------
diff --cc docs/src/upgrade/release-3.3.x.asciidoc
index a3a53cf,baae438..b5033b5
--- a/docs/src/upgrade/release-3.3.x.asciidoc
+++ b/docs/src/upgrade/release-3.3.x.asciidoc
@@@ -225,23 -211,8 +225,25 @@@ The following deprecated classes, metho
  ** `org.apache.tinkerpop.gremlin.process.traversal.util.OrP(P...)`
  ** `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptFunction`
  ** `org.apache.tinkerpop.gremlin.process.traversal.util.TraversalScriptHelper`
 +** `org.apache.tinkerpop.gremlin.process.traversal.Order.keyIncr`
 +** `org.apache.tinkerpop.gremlin.process.traversal.Order.valueIncr`
 +** `org.apache.tinkerpop.gremlin.process.traversal.Order.keyDecr`
 +** `org.apache.tinkerpop.gremlin.process.traversal.Order.valueIncr`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.GraphTraversal.mapKeys()`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.GraphTraversal.mapValues()`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addV(Object...)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addE(Direction, String, String, Object...)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addOutE(String, String, Object...)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#addInV(String, String, Object...)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.Bindings()`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource#withBindings(Bindings)`
 +** `org.apache.tinkerpop.gremlin.structure.Transaction.submit(Function)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#sack(BiFunction,String)`
 +** `org.apache.tinkerpop.gremlin.process.traversal.strategy.finalization.LazyBarrierStrategy`
 +** `org.apache.tinkerpop.gremlin.process.traversal.TraversalSideEffects` (various methods)
 +** `org.apache.tinkerpop.gremlin.process.computer.traversal.step.VertexComputing#generateComputer(Graph)`
+ ** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#groupV3d0(String)`
+ ** `org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal#groupV3d0()`
  ** `org.apache.tinkerpop.gremlin.structure.Graph.Features.VertexPropertyFeatures#supportsAddProperty()`
  ** `org.apache.tinkerpop.gremlin.structure.Graph.Features.VertexPropertyFeatures#FEATURE_ADD_PROPERTY`
  ** `org.apache.tinkerpop.gremlin.structure.Graph.OptIn#SUITE_GROOVY_PROCESS_STANDARD`
@@@ -351,11 -306,7 +353,12 @@@ link:https://issues.apache.org/jira/bro
  link:https://issues.apache.org/jira/browse/TINKERPOP-1622[TINKERPOP-1622],
  link:https://issues.apache.org/jira/browse/TINKERPOP-1651[TINKERPOP-1651],
  link:https://issues.apache.org/jira/browse/TINKERPOP-1694[TINKERPOP-1694],
 -link:https://issues.apache.org/jira/browse/TINKERPOP-1700[TINKERPOP-1700]
 +link:https://issues.apache.org/jira/browse/TINKERPOP-1700[TINKERPOP-1700],
 +link:https://issues.apache.org/jira/browse/TINKERPOP-1706[TINKERPOP-1706],
 +link:https://issues.apache.org/jira/browse/TINKERPOP-1721[TINKERPOP-1721],
 +link:https://issues.apache.org/jira/browse/TINKERPOP-1719[TINKERPOP-1719],
- link:https://issues.apache.org/jira/browse/TINKERPOP-1720[TINKERPOP-1720]
++link:https://issues.apache.org/jira/browse/TINKERPOP-1720[TINKERPOP-1720],
++link:https://issues.apache.org/jira/browse/TINKERPOP-880[TINKERPOP-880]
  
  Gremlin-server.sh and Init Scripts
  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/GraphTraversal.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/process/traversal/dsl/graph/__.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-core/src/main/java/org/apache/tinkerpop/gremlin/structure/io/gryo/GryoVersion.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-python/src/main/jython/gremlin_python/process/graph_traversal.py
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/ProcessComputerSuite.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/gremlin-test/src/main/java/org/apache/tinkerpop/gremlin/process/ProcessStandardSuite.java
----------------------------------------------------------------------

http://git-wip-us.apache.org/repos/asf/tinkerpop/blob/489533ff/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphPlayTest.java
----------------------------------------------------------------------
diff --cc tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphPlayTest.java
index e3c20b5,6ab8827..eeb4f38
--- a/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphPlayTest.java
+++ b/tinkergraph-gremlin/src/test/java/org/apache/tinkerpop/gremlin/tinkergraph/structure/TinkerGraphPlayTest.java
@@@ -21,9 -21,9 +21,7 @@@ package org.apache.tinkerpop.gremlin.ti
  import org.apache.tinkerpop.gremlin.jsr223.JavaTranslator;
  import org.apache.tinkerpop.gremlin.process.computer.Computer;
  import org.apache.tinkerpop.gremlin.process.traversal.Bytecode;
--import org.apache.tinkerpop.gremlin.process.traversal.Operator;
  import org.apache.tinkerpop.gremlin.process.traversal.Order;
--import org.apache.tinkerpop.gremlin.process.traversal.Scope;
  import org.apache.tinkerpop.gremlin.process.traversal.Traversal;
  import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversal;
  import org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.GraphTraversalSource;
@@@ -53,8 -53,8 +51,6 @@@ import static org.apache.tinkerpop.grem
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.as;
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.both;
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.choose;
--import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.count;
--import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.fold;
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.has;
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.in;
  import static org.apache.tinkerpop.gremlin.process.traversal.dsl.graph.__.out;
@@@ -106,44 -106,36 +102,7 @@@ public class TinkerGraphPlayTest 
              //assertEquals(result, t.next());
          }));
      }
 -    
 -    @Test
 -    @Ignore
 -    public void testPlay() {
 -        Graph g = TinkerGraph.open();
 -        Vertex v1 = g.addVertex(T.id, "1", "animal", "males");
 -        Vertex v2 = g.addVertex(T.id, "2", "animal", "puppy");
 -        Vertex v3 = g.addVertex(T.id, "3", "animal", "mama");
 -        Vertex v4 = g.addVertex(T.id, "4", "animal", "puppy");
 -        Vertex v5 = g.addVertex(T.id, "5", "animal", "chelsea");
 -        Vertex v6 = g.addVertex(T.id, "6", "animal", "low");
 -        Vertex v7 = g.addVertex(T.id, "7", "animal", "mama");
 -        Vertex v8 = g.addVertex(T.id, "8", "animal", "puppy");
 -        Vertex v9 = g.addVertex(T.id, "9", "animal", "chula");
 -
 -        v1.addEdge("link", v2, "weight", 2f);
 -        v2.addEdge("link", v3, "weight", 3f);
 -        v2.addEdge("link", v4, "weight", 4f);
 -        v2.addEdge("link", v5, "weight", 5f);
 -        v3.addEdge("link", v6, "weight", 1f);
 -        v4.addEdge("link", v6, "weight", 2f);
 -        v5.addEdge("link", v6, "weight", 3f);
 -        v6.addEdge("link", v7, "weight", 2f);
 -        v6.addEdge("link", v8, "weight", 3f);
 -        v7.addEdge("link", v9, "weight", 1f);
 -        v8.addEdge("link", v9, "weight", 7f);
 -
 -        g.traversal().withSack(Float.MIN_VALUE).V(v1).repeat(outE().sack(Operator.max, "weight").inV()).times(5).sack().forEachRemaining(x -> logger.info(x.toString()));
 -    }
  
-     @Test
-     @Ignore
-     public void benchmarkGroup() throws Exception {
-         Graph graph = TinkerGraph.open();
-         GraphTraversalSource g = graph.traversal();
-         graph.io(GraphMLIo.build()).readGraph("../data/grateful-dead.xml");
-         /////////
- 
-         //g.V().group().by(T.label).by(values("name")).forEachRemaining(x -> logger.info(x.toString()));
- 
-         System.out.println("group: " + g.V().both("followedBy").both("followedBy").group().by("songType").by(count()).next());
-         System.out.println("groupV3d0: " + g.V().both("followedBy").both("followedBy").groupV3d0().by("songType").by().by(__.count(Scope.local)).next());
- 
-         //
-         System.out.println("\n\nBig Values -- by(songType)");
- 
-         System.out.println("group: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").group().by("songType").by(count()).next()));
-         System.out.println("groupV3d0: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").groupV3d0().by("songType").by().by(__.count(Scope.local)).next()) + "\n");
- 
-         ///
- 
-         System.out.println("group: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").group().by("songType").by(fold()).next()));
-         System.out.println("groupV3d0: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").groupV3d0().by("songType").by().next()));
- 
-         ///
-         System.out.println("\n\nBig Keys -- by(name)");
- 
-         System.out.println("group: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").group().by("name").by(count()).next()));
-         System.out.println("groupV3d0: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").groupV3d0().by("name").by().by(__.count(Scope.local)).next()) + "\n");
- 
-         ///
- 
-         System.out.println("group: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").group().by("name").by(fold()).next()));
-         System.out.println("groupV3d0: " + TimeUtil.clock(10, () -> g.V().both("followedBy").both("followedBy").groupV3d0().by("name").by().next()));
- 
-     }
- 
     /* @Test
      public void testTraversalDSL() throws Exception {
          Graph g = TinkerFactory.createClassic();