You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Patrick Hunt (JIRA)" <ji...@apache.org> on 2010/04/10 23:18:41 UTC
[jira] Created: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
zookeeper.jute.h fails to compile with -pedantic
-------------------------------------------------
Key: ZOOKEEPER-738
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
Project: Zookeeper
Issue Type: Bug
Components: c client
Affects Versions: 3.3.0
Reporter: Patrick Hunt
Assignee: Patrick Hunt
Fix For: 3.3.1, 3.4.0
/home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
/home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
/home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt reassigned ZOOKEEPER-738:
--------------------------------------
Assignee: Jozef Hatala (was: Patrick Hunt)
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-738:
-----------------------------------
Status: Patch Available (was: Open)
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-738:
-----------------------------------
Status: Resolved (was: Patch Available)
Hadoop Flags: [Reviewed]
Resolution: Fixed
+1, looks good, thanks Jozef!
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Jozef Hatala (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jozef Hatala updated ZOOKEEPER-738:
-----------------------------------
Attachment: semi.patch
The attached patch removes the extra semicolon after the call to JType.genCDecl (which comes with its own semicolon already):
src/java/main/org/apache/jute/compiler/JType.java:
52 String genCDecl(String name) {
53 return " " + mCName + " "+name+";\n";
54 }
The attached diff is against http://svn.apache.org/repos/asf/hadoop/zookeeper/trunk at revision 932666 specifically.
(Regenerated the files like this: rm -rf src/{c,java}/generated/ && ant compile_jute)
Testing done: I diff:ed the C and Java files that "ant compile_jute" generates in the ZK tree *with* and *without* this patch applied, and I confirmed that the only difference between the two is that with the patch applied the extra semicolon is not present any more. (Diff:ed like this: diff -ru src{.orig,}/c/generated/)
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Patrick Hunt
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-738:
-----------------------------------
Status: Open (was: Patch Available)
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Patrick Hunt updated ZOOKEEPER-738:
-----------------------------------
Status: Patch Available (was: Open)
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859912#action_12859912 ]
Hadoop QA commented on ZOOKEEPER-738:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442124/semi.patch
against trunk revision 936624.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h1.grid.sp2.yahoo.net/67/console
This message is automatically generated.
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (ZOOKEEPER-738) zookeeper.jute.h fails to compile
with -pedantic
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-738?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12859941#action_12859941 ]
Hadoop QA commented on ZOOKEEPER-738:
-------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12442124/semi.patch
against trunk revision 936624.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no tests are needed for this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: http://hudson.zones.apache.org/hudson/job/Zookeeper-Patch-h8.grid.sp2.yahoo.net/147/console
This message is automatically generated.
> zookeeper.jute.h fails to compile with -pedantic
> -------------------------------------------------
>
> Key: ZOOKEEPER-738
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-738
> Project: Zookeeper
> Issue Type: Bug
> Components: c client
> Affects Versions: 3.3.0
> Reporter: Patrick Hunt
> Assignee: Jozef Hatala
> Fix For: 3.3.1, 3.4.0
>
> Attachments: semi.patch
>
>
> /home/y/include/zookeeper/zookeeper.jute.h:96: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:158: error: extra semicolon
> /home/y/include/zookeeper/zookeeper.jute.h:288: error: extra semicolon
> the code generator needs to be updated to not output a naked semi
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.