RE: svn commit: r38186 - trunk/subversion/include

[Bert Huijben <rh...@sharpsvn.net>]

> -----Original Message-----
> From: Stefan Sperling [mailto:stsp@elego.de]
> Sent: woensdag 24 juni 2009 16:45
> To: svn@subversion.tigris.org
> Subject: svn commit: r38186 - trunk/subversion/include
> 
> Author: stsp
> Date: Wed Jun 24 07:45:20 2009
> New Revision: 38186
> 
> Log:
> * subversion/include/svn_client.h
>  (svn_client_commit_item3_t): New member 'adm_access', so every commit
>   item can refer to its adm_access easily.
>  (svn_client_commit_item3_dup): Change docstring to indicate
>   that the adm_access member will be shared between copies.
> 
> Patch-by: HuiHuang <ye...@yahoo.com.cn>
> (log message tweaked by me)
> 
> Modified:
>    trunk/subversion/include/svn_client.h
> 
> Modified: trunk/subversion/include/svn_client.h
> URL:
> http://svn.collab.net/viewvc/svn/trunk/subversion/include/svn_client.h?
> pathrev=38186&r1=38185&r2=38186
> =======================================================================
> =======
> --- trunk/subversion/include/svn_client.h	Wed Jun 24 07:36:23 2009
> 	(r38185)
> +++ trunk/subversion/include/svn_client.h	Wed Jun 24 07:45:20 2009
> 	(r38186)
> @@ -465,6 +465,9 @@ typedef struct svn_client_commit_item3_t
>     * same lifetime as this data structure.
>     */
>    apr_array_header_t *outgoing_prop_changes;
> +
> +  /** adm_access of this item */
> +  svn_wc_adm_access_t *adm_access;
>  } svn_client_commit_item3_t;

This addition needs a @since doxygen tag, and probably a '###' suggesting
that this field should be removed once we have one global svn_wc_context_t,
that can handle multiple working copies.

(And personally I would prefer not to hand off adm_access instances to third
party handlers of the logmessage callback, because you are not supposed to
do any working copy operations in this state).

	Bert

------------------------------------------------------
http://subversion.tigris.org/ds/viewMessage.do?dsForumId=462&dsMessageId=2364961

Re: svn commit: r38186 - trunk/subversion/include

[Stefan Sperling <st...@elego.de>]

On Wed, Jun 24, 2009 at 04:56:15PM +0200, Bert Huijben wrote:
> > @@ -465,6 +465,9 @@ typedef struct svn_client_commit_item3_t
> >     * same lifetime as this data structure.
> >     */
> >    apr_array_header_t *outgoing_prop_changes;
> > +
> > +  /** adm_access of this item */
> > +  svn_wc_adm_access_t *adm_access;
> >  } svn_client_commit_item3_t;
> 
> This addition needs a @since doxygen tag, and probably a '###' suggesting
> that this field should be removed once we have one global svn_wc_context_t,
> that can handle multiple working copies.

r38187
 
> (And personally I would prefer not to hand off adm_access instances to third
> party handlers of the logmessage callback, because you are not supposed to
> do any working copy operations in this state).

Well, commit items as a data type are also used for other things apart
from writing log messages. Would you rather create a new data type?

Stefan