[GitHub] [kafka] divijvaidya commented on a diff in pull request #13719: MINOR:Fix illogical log in fetchOffsetAndTruncate method

["divijvaidya (via GitHub)" <gi...@apache.org>]

divijvaidya commented on code in PR #13719:
URL: https://github.com/apache/kafka/pull/13719#discussion_r1199008645


##########
core/src/main/scala/kafka/server/AbstractFetcherThread.scala:
##########
@@ -680,12 +680,15 @@ abstract class AbstractFetcherThread(name: String,
        */
       val offsetAndEpoch = leader.fetchEarliestOffset(topicPartition, currentLeaderEpoch)
       val leaderStartOffset = offsetAndEpoch.offset
-      warn(s"Reset fetch offset for partition $topicPartition from $replicaEndOffset to current " +
-        s"leader's start offset $leaderStartOffset")
       val offsetToFetch = Math.max(leaderStartOffset, replicaEndOffset)
+      info(s"Reset fetch offset for partition $topicPartition from $replicaEndOffset to " +
+        s"new fetch offset $offsetToFetch")
       // Only truncate log when current leader's log start offset is greater than follower's log end offset.
-      if (leaderStartOffset > replicaEndOffset)
+      if (leaderStartOffset > replicaEndOffset) {
         truncateFullyAndStartAt(topicPartition, leaderStartOffset)
+        warn(s"Truncate fully and start at leader's start offset $leaderStartOffset for partition $topicPartition " +

Review Comment:
   This log should probably be placed before the call to truncateFullyAndStartAt. Placing the line "before" will help in debugging cases where truncation fails for some reason. It would help us understand what code path was being executed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org