You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sachchidanand Vaidya <va...@juniper.net> on 2014/01/14 02:54:53 UTC

Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16841/
-----------------------------------------------------------

Review request for cloudstack.


Repository: cloudstack-git


Description
-------

This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4).


Diffs
-----

  api/src/com/cloud/network/PhysicalNetwork.java 55b18e6 
  plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 
  plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466 
  ui/scripts/ui-custom/zoneWizard.js 28df193 

Diff: https://reviews.apache.org/r/16841/diff/


Testing
-------

Unit testing done.


Thanks,

Sachchidanand Vaidya

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

Posted by Sachchidanand Vaidya <va...@juniper.net>.
It's not a new feature. Only new isolationMethod created for contrail network plugin.

Best Regards,
Sachin

From: Sheng Yang <sh...@yasker.org>>
Date: Tuesday, January 14, 2014 1:57 PM
To: David Nalley <da...@gnsa.us>>
Cc: "dev@cloudstack.apache.org<ma...@cloudstack.apache.org>" <de...@cloudstack.apache.org>>, Admin <va...@juniper.net>>
Subject: Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

I don't think it's a feature after checking the patch.

It's basically they called it "L3VPN" instead of "GRE" in the patch I think.

--Sheng


On Tue, Jan 14, 2014 at 1:55 PM, David Nalley <da...@gnsa.us>> wrote:
Why are we adding functionality after 4.3 has closed?

--David

On Tue, Jan 14, 2014 at 4:53 PM, Sheng Yang <sh...@yasker.org>> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16841/#review31810
> -----------------------------------------------------------
>
> Ship it!
>
>
> Applied to 4.3 branch.
>
> Thanks.
>
>
> - Sheng Yang
>
>
> On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16841/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 14, 2014, 1:54 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4).
>>
>>
>> Diffs
>> -----
>>
>>   api/src/com/cloud/network/PhysicalNetwork.java 55b18e6
>>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534
>>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466
>>   ui/scripts/ui-custom/zoneWizard.js 28df193
>>
>> Diff: https://reviews.apache.org/r/16841/diff/
>>
>>
>> Testing
>> -------
>>
>> Unit testing done.
>>
>>
>> Thanks,
>>
>> Sachchidanand Vaidya
>>
>>
>

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

Posted by Sheng Yang <sh...@yasker.org>.
I don't think it's a feature after checking the patch.

It's basically they called it "L3VPN" instead of "GRE" in the patch I think.

--Sheng


On Tue, Jan 14, 2014 at 1:55 PM, David Nalley <da...@gnsa.us> wrote:

> Why are we adding functionality after 4.3 has closed?
>
> --David
>
> On Tue, Jan 14, 2014 at 4:53 PM, Sheng Yang <sh...@yasker.org> wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/16841/#review31810
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > Applied to 4.3 branch.
> >
> > Thanks.
> >
> >
> > - Sheng Yang
> >
> >
> > On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote:
> >>
> >> -----------------------------------------------------------
> >> This is an automatically generated e-mail. To reply, visit:
> >> https://reviews.apache.org/r/16841/
> >> -----------------------------------------------------------
> >>
> >> (Updated Jan. 14, 2014, 1:54 a.m.)
> >>
> >>
> >> Review request for cloudstack.
> >>
> >>
> >> Repository: cloudstack-git
> >>
> >>
> >> Description
> >> -------
> >>
> >> This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4).
> >>
> >>
> >> Diffs
> >> -----
> >>
> >>   api/src/com/cloud/network/PhysicalNetwork.java 55b18e6
> >>
> plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java
> 6587534
> >>
> plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java
> bbff466
> >>   ui/scripts/ui-custom/zoneWizard.js 28df193
> >>
> >> Diff: https://reviews.apache.org/r/16841/diff/
> >>
> >>
> >> Testing
> >> -------
> >>
> >> Unit testing done.
> >>
> >>
> >> Thanks,
> >>
> >> Sachchidanand Vaidya
> >>
> >>
> >
>

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

Posted by David Nalley <da...@gnsa.us>.
Why are we adding functionality after 4.3 has closed?

--David

On Tue, Jan 14, 2014 at 4:53 PM, Sheng Yang <sh...@yasker.org> wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16841/#review31810
> -----------------------------------------------------------
>
> Ship it!
>
>
> Applied to 4.3 branch.
>
> Thanks.
>
>
> - Sheng Yang
>
>
> On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote:
>>
>> -----------------------------------------------------------
>> This is an automatically generated e-mail. To reply, visit:
>> https://reviews.apache.org/r/16841/
>> -----------------------------------------------------------
>>
>> (Updated Jan. 14, 2014, 1:54 a.m.)
>>
>>
>> Review request for cloudstack.
>>
>>
>> Repository: cloudstack-git
>>
>>
>> Description
>> -------
>>
>> This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4).
>>
>>
>> Diffs
>> -----
>>
>>   api/src/com/cloud/network/PhysicalNetwork.java 55b18e6
>>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534
>>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466
>>   ui/scripts/ui-custom/zoneWizard.js 28df193
>>
>> Diff: https://reviews.apache.org/r/16841/diff/
>>
>>
>> Testing
>> -------
>>
>> Unit testing done.
>>
>>
>> Thanks,
>>
>> Sachchidanand Vaidya
>>
>>
>

Re: Review Request 16841: (ACS4.3): Add new physical network isolationMethod (L3VPN) for Juniper Contrail plugin.

Posted by Sheng Yang <sh...@yasker.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16841/#review31810
-----------------------------------------------------------

Ship it!


Applied to 4.3 branch.

Thanks.


- Sheng Yang


On Jan. 14, 2014, 1:54 a.m., Sachchidanand Vaidya wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16841/
> -----------------------------------------------------------
> 
> (Updated Jan. 14, 2014, 1:54 a.m.)
> 
> 
> Review request for cloudstack.
> 
> 
> Repository: cloudstack-git
> 
> 
> Description
> -------
> 
> This diff is on ACS4.3 (Similar to Review Request 16258 for ACS-4.4).
> 
> 
> Diffs
> -----
> 
>   api/src/com/cloud/network/PhysicalNetwork.java 55b18e6 
>   plugins/network-elements/juniper-contrail/src/org/apache/cloudstack/network/contrail/management/ContrailGuru.java 6587534 
>   plugins/network-elements/juniper-contrail/test/org/apache/cloudstack/network/contrail/management/ManagementServerMock.java bbff466 
>   ui/scripts/ui-custom/zoneWizard.js 28df193 
> 
> Diff: https://reviews.apache.org/r/16841/diff/
> 
> 
> Testing
> -------
> 
> Unit testing done.
> 
> 
> Thanks,
> 
> Sachchidanand Vaidya
> 
>