[jira] [Commented] (HBASE-26191) Annotate shaded generated protobuf as InterfaceAudience.Private

["Nick Dimiduk (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-26191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17399984#comment-17399984 ] 

Nick Dimiduk commented on HBASE-26191:
--------------------------------------

An interface for decoration of generated classes looks like a [long-standing request| https://github.com/protocolbuffers/protobuf/issues/42]. As far as I can tell, it's not available as of now, expect perhaps through an undocumented flag on recent versions of the compiler.

Perhaps we can use something like [Rewrite|https://github.com/openrewrite/rewrite-maven-plugin] to annotate the generated classes during the build process.

> Annotate shaded generated protobuf as InterfaceAudience.Private
> ---------------------------------------------------------------
>
>                 Key: HBASE-26191
>                 URL: https://issues.apache.org/jira/browse/HBASE-26191
>             Project: HBase
>          Issue Type: Task
>          Components: Coprocessors, Protobufs
>            Reporter: Michael Stack
>            Priority: Major
>
> Annotate generated shaded protobufs as InterfaceAudience.Private. It might not be able to add the annotation to each class; at a minimum update the doc on our story around shaded internal protobufs.
> See the prompting mailing list discussion here: [https://lists.apache.org/thread.html/r9e6eb11106727d245f6eb2a5023823901637971d6ed0f0aedaf8d149%40%3Cdev.hbase.apache.org%3E]
> So far the consensus has it that the shaded generated protobuf should be made IA.Private.  Will wait on it to settle.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)