You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by "Aklakan (via GitHub)" <gi...@apache.org> on 2023/03/17 09:30:36 UTC
[GitHub] [jena] Aklakan opened a new pull request, #1802: Prevents needless materialization of lexical forms
Aklakan opened a new pull request, #1802:
URL: https://github.com/apache/jena/pull/1802
GitHub issue resolved #1801
Defer materialization of lexical form after it is ensured that the node's datatype is in the XSD namespace.
See the [Apache Jena "Contributing" guide](https://github.com/apache/jena/blob/main/CONTRIBUTING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs merged pull request #1802: GH-1801: Prevents needless materialization of lexical forms
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs merged PR #1802:
URL: https://github.com/apache/jena/pull/1802
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a diff in pull request #1802: GH-1801: Prevents needless materialization of lexical forms
Posted by "afs (via GitHub)" <gi...@apache.org>.
afs commented on code in PR #1802:
URL: https://github.com/apache/jena/pull/1802#discussion_r1140115990
##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java:
##########
Review Comment:
While you are at it, please also change line new-690 s/lit.getLexicalForm()/lex/.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] Aklakan commented on a diff in pull request #1802: GH-1801: Prevents needless materialization of lexical forms
Posted by "Aklakan (via GitHub)" <gi...@apache.org>.
Aklakan commented on code in PR #1802:
URL: https://github.com/apache/jena/pull/1802#discussion_r1140188871
##########
jena-arq/src/main/java/org/apache/jena/sparql/expr/NodeValue.java:
##########
Review Comment:
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org