You are viewing a plain text version of this content. The canonical link for it is here.

Posted to yarn-issues@hadoop.apache.org by "Rohith (JIRA)" <ji...@apache.org> on 2015/06/08 04:36:00 UTC

[jira] [Commented] (YARN-3780) Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition

    [ https://issues.apache.org/jira/browse/YARN-3780?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14576550#comment-14576550 ] 

Rohith commented on YARN-3780:
------------------------------

Makse sense, 
+1 lgtm (non-binding)

> Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition
> -----------------------------------------------------------------------------
>
>                 Key: YARN-3780
>                 URL: https://issues.apache.org/jira/browse/YARN-3780
>             Project: Hadoop YARN
>          Issue Type: Bug
>          Components: resourcemanager
>    Affects Versions: 2.7.0
>            Reporter: zhihai xu
>            Assignee: zhihai xu
>            Priority: Minor
>         Attachments: YARN-3780.000.patch
>
>
> Should use equals when compare Resource in RMNodeImpl#ReconnectNodeTransition to avoid unnecessary NodeResourceUpdateSchedulerEvent.
> The current code use {{!=}} to compare Resource totalCapability, which will compare reference not the real value in Resource. So we should use equals to compare Resource.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)