[GitHub] [hadoop] symious commented on a diff in pull request #5863: HADOOP-18816. Rebuild exceptions on Client side

["symious (via GitHub)" <gi...@apache.org>]

symious commented on code in PR #5863:
URL: https://github.com/apache/hadoop/pull/5863#discussion_r1269244864


##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/ipc/TestProtoBufRpc.java:
##########
@@ -329,7 +331,30 @@ public void testProtoBufRandomException() throws Exception {
           .isEqualTo(RpcErrorCodeProto.ERROR_APPLICATION);
     }
   }
-  
+
+  @Test (timeout=5000)
+  public void testProtoBufReconstructableException() throws Exception {
+    //No test with legacy
+    assumeFalse(testWithLegacy);
+    TestRpcService client = getClient(addr, conf);
+
+    try {
+      client.error3(null, newEmptyRequest());
+    } catch (ServiceException se) {
+      assertThat(se.getCause()).isInstanceOf(RemoteException.class);

Review Comment:
   Updated the following assert, please have a look.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org