You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "villebro (via GitHub)" <gi...@apache.org> on 2023/06/07 10:31:08 UTC
[GitHub] [superset] villebro opened a new pull request, #24306: [WIP] chore: reorder k-v migration for 2.1
villebro opened a new pull request, #24306:
URL: https://github.com/apache/superset/pull/24306
### SUMMARY
Reorder a few migrations for the 2.1.1 release:
Original order:
> 4ce1d9b25135
> f3c2d8ec8595
> <2.1.0 cutoff>
> c0a3ea245b61
> ...
> 7e67aecbf3f1
> 9c2a5681ddfd (pickle key-value migration)
> 4ea966691069
New order:
> 4ce1d9b25135
> f3c2d8ec8595
> <2.1.0 cutoff>
> 9c2a5681ddfd (pickle key-value migration)
> <2.1.1 cutoff>
> c0a3ea245b61
> ...
> 7e67aecbf3f1
> 4ea966691069
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TESTING INSTRUCTIONS
<!--- Required! What steps can be taken to manually verify the changes? -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] villebro merged pull request #24306: chore: reorder k-v migration for 2.1.1
Posted by "villebro (via GitHub)" <gi...@apache.org>.
villebro merged PR #24306:
URL: https://github.com/apache/superset/pull/24306
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on pull request #24306: chore: reorder k-v migration for 2.1.1
Posted by "michael-s-molina (via GitHub)" <gi...@apache.org>.
michael-s-molina commented on PR #24306:
URL: https://github.com/apache/superset/pull/24306#issuecomment-1581300975
@john-bodley Could you check if this re-ordering will affect our release or it's ok to merge it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #24306: [WIP] chore: reorder k-v migration for 2.1
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #24306:
URL: https://github.com/apache/superset/pull/24306#issuecomment-1580481445
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/24306?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#24306](https://app.codecov.io/gh/apache/superset/pull/24306?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (fc91207) into [master](https://app.codecov.io/gh/apache/superset/commit/ede6acdb3afdf4003359b0c6e2aa8c4b154773ae?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (ede6acd) will **decrease** coverage by `9.43%`.
> The diff coverage is `n/a`.
> :exclamation: Current head fc91207 differs from pull request most recent head 2c5b970. Consider uploading reports for the commit 2c5b970 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24306 +/- ##
==========================================
- Coverage 66.53% 57.10% -9.43%
==========================================
Files 1957 1957
Lines 75623 75623
Branches 8224 8224
==========================================
- Hits 50312 43187 -7125
- Misses 23202 30327 +7125
Partials 2109 2109
```
| Flag | Coverage Δ | |
|---|---|---|
| mysql | `?` | |
| postgres | `?` | |
| presto | `53.32% <ø> (?)` | |
| python | `59.64% <ø> (-19.49%)` | :arrow_down: |
| sqlite | `?` | |
| unit | `53.44% <ø> (?)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
[see 360 files with indirect coverage changes](https://app.codecov.io/gh/apache/superset/pull/24306/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org