[GitHub] mikewalch commented on a change in pull request #965: Fix code quality issues found by lgtm

[GitBox <gi...@apache.org>]

mikewalch commented on a change in pull request #965: Fix code quality issues found by lgtm
URL: https://github.com/apache/accumulo/pull/965#discussion_r257521928
 
 

 ##########
 File path: server/base/src/main/java/org/apache/accumulo/server/master/state/TabletStateChangeIterator.java
 ##########
 @@ -267,10 +267,6 @@ public static void setMasterState(IteratorSetting cfg, MasterState state) {
 
   public static void setShuttingDown(IteratorSetting cfg, Set<TServerInstance> servers) {
     if (servers != null) {
-      List<String> serverList = new ArrayList<>();
-      for (TServerInstance server : servers) {
-        serverList.add(server.toString());
-      }
       cfg.addOption(SHUTTING_DOWN_OPTION, Joiner.on(",").join(servers));
 
 Review comment:
   I wrote some similar code and it looks like it does

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services