You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/08/29 06:40:23 UTC
[GitHub] [hudi] nonggialiang opened a new pull request, #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
nonggialiang opened a new pull request, #6524:
URL: https://github.com/apache/hudi/pull/6524
…act_task
### Change Logs
Use mail-box executor to send compaction-commit-event in CompactFunction.
### Impact
Potential bug fixed.
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [x] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [x] Change Logs and Impact were stated clearly
- [x] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] littleeleventhwolf commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
littleeleventhwolf commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1369500385
> Does #7399 solve your problem here ?
Yeah, we cherry-pick [#7399](https://github.com/apache/hudi/pull/7399). But if user enable latency-marker, there is still thread-safety problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-2019222746
yeah, just need to reach concensus.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1229884432
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29b3d898edfb9b3e18d62a04881dc8c274449111 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 closed pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
URL: https://github.com/apache/hudi/pull/6524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1231734097
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
}, {
"hash" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29b3d898edfb9b3e18d62a04881dc8c274449111 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008)
* e2579405afe88655f8f05f134f8c3ede38733b7d UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1369691323
> > Does #7399 solve your problem here ?
>
> Yeah, we cherry-pick [#7399](https://github.com/apache/hudi/pull/7399). But if user enable latency-marker, there is still thread-safety problem.
Does the Operator has any interface to handle the latency-marker yet ? Just like what we do to watermark.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task [hudi]
Posted by "yihua (via GitHub)" <gi...@apache.org>.
yihua commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-2019218059
@danny0405 is this PR still useful?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
danny0405 commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1369495266
Does https://github.com/apache/hudi/pull/7399 solves your problem here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #6524:
URL: https://github.com/apache/hudi/pull/6524#discussion_r958092196
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java:
##########
@@ -130,4 +143,38 @@ private HoodieWriteConfig reloadWriteConfig() throws Exception {
public void setExecutor(NonThrownExecutor executor) {
this.executor = executor;
}
+
+ private void sendEventByMailBox(Collector<CompactionCommitEvent> collector, CompactionCommitEvent commitEvent) {
+ mailboxExecutorAdapter.execute(() -> collector.collect(commitEvent),
+ "Send compaction commit event by mailbox.");
+ }
Review Comment:
Thanks, we may need to figure out more simpler way for `collector` concurrency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1229878789
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29b3d898edfb9b3e18d62a04881dc8c274449111 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1231741893
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
}, {
"hash" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11052",
"triggerID" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29b3d898edfb9b3e18d62a04881dc8c274449111 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008)
* e2579405afe88655f8f05f134f8c3ede38733b7d Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task [hudi]
Posted by "danny0405 (via GitHub)" <gi...@apache.org>.
danny0405 commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-3605627626
@littleeleventhwolf we introduce a new `MaskingOutputAdapter` in https://github.com/apache/hudi/pull/8379 to address your concern 1, for 2, it may not make much sense for compaction/clustering operators to propagate the watermark, will close it first, will reopen it if we have real use case for concern 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] nonggialiang commented on a diff in pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
nonggialiang commented on code in PR #6524:
URL: https://github.com/apache/hudi/pull/6524#discussion_r958479996
##########
hudi-flink-datasource/hudi-flink/src/main/java/org/apache/hudi/sink/compact/CompactFunction.java:
##########
@@ -130,4 +143,38 @@ private HoodieWriteConfig reloadWriteConfig() throws Exception {
public void setExecutor(NonThrownExecutor executor) {
this.executor = executor;
}
+
+ private void sendEventByMailBox(Collector<CompactionCommitEvent> collector, CompactionCommitEvent commitEvent) {
+ mailboxExecutorAdapter.execute(() -> collector.collect(commitEvent),
+ "Send compaction commit event by mailbox.");
+ }
Review Comment:
Just pushed a new implementaion using AsynFunction of flink.
And fixed the same potential problem in clustering operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1230118759
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 29b3d898edfb9b3e18d62a04881dc8c274449111 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
codope commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1340948353
@nonggialiang Can you please rebase?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1232193821
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11008",
"triggerID" : "29b3d898edfb9b3e18d62a04881dc8c274449111",
"triggerType" : "PUSH"
}, {
"hash" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11052",
"triggerID" : "e2579405afe88655f8f05f134f8c3ede38733b7d",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* e2579405afe88655f8f05f134f8c3ede38733b7d Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11052)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] littleeleventhwolf commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
littleeleventhwolf commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1369438888
@nonggialiang After using AsyncFunction to rewrite the asynchronous compaction logic, have you solved the problem described in [HUDI-4717](https://issues.apache.org/jira/projects/HUDI/issues/HUDI-4717)？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] littleeleventhwolf commented on pull request #6524: [HUDI-4717] CompactionCommitEvent message corrupted when sent by compact_task
Posted by GitBox <gi...@apache.org>.
littleeleventhwolf commented on PR #6524:
URL: https://github.com/apache/hudi/pull/6524#issuecomment-1370415430
> > > Does #7399 solve your problem here ?
> >
> >
> > Yeah, we cherry-pick [#7399](https://github.com/apache/hudi/pull/7399). But if user enable latency-marker, there is still thread-safety problem.
>
> Does the Operator has any interface to handle the latency-marker yet ? Just like what we do to watermark.
We can provide an empty method `processLatencyMarker(LatencyMarker latencyMarker)` to not propagate the latency-marker. But I don't think this is an elegant way, for two reasons:
1) if Flink generates a new `StreamElement` in future version, we also need to provide an empty method for compatibility;
2) if users want to use `Watermark` or `LatencyMarker` do some other work in Operator `Sink:compact_commit`, an empty method that does not propagate these events cannot support users' requirement.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org