You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by "1Burhanuddin (via GitHub)" <gi...@apache.org> on 2026/06/03 10:52:25 UTC
[PR] fix: correct typos in config.py and models_test.py comments [superset]
1Burhanuddin opened a new pull request, #40706:
URL: https://github.com/apache/superset/pull/40706
### SUMMARY
Fixed two small spelling typos in code comments:
1. `superset/config.py` line 1196: `annd` → `and`
2. - Comment said: "This feature is deprecated, annd will be removed"
2. `tests/unit_tests/connectors/sqla/models_test.py` line 272: `hanndle` → `handle`
3. - Docstring said: "can hanndle custom SQL"
### TESTING INSTRUCTIONS
No functional changes — only comment/docstring text was modified. No tests needed.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] - [ ] Required feature flags:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: correct typos in config.py and models_test.py comments [superset]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #40706:
URL: https://github.com/apache/superset/pull/40706#issuecomment-4613565721
## [Codecov](https://app.codecov.io/gh/apache/superset/pull/40706?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 63.29%. Comparing base ([`b9dc9d7`](https://app.codecov.io/gh/apache/superset/commit/b9dc9d722e62d2417076272e29c08280ac6c51d2?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`2896826`](https://app.codecov.io/gh/apache/superset/commit/289682623f6dd8d22568d7368693c01ca4c56238?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 13 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #40706 +/- ##
==========================================
- Coverage 64.08% 63.29% -0.80%
==========================================
Files 2663 2663
Lines 143289 143289
Branches 32952 32952
==========================================
- Hits 91832 90695 -1137
- Misses 49871 51002 +1131
- Partials 1586 1592 +6
```
| [Flag](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [hive](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `39.79% <ø> (ø)` | |
| [mysql](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [postgres](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [presto](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `41.39% <ø> (ø)` | |
| [python](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.33% <ø> (-1.70%)` | :arrow_down: |
| [sqlite](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `58.16% <ø> (ø)` | |
| [unit](https://app.codecov.io/gh/apache/superset/pull/40706/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/superset/pull/40706?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] chore: correct typos in config.py and models_test.py comments [superset]
Posted by "hainenber (via GitHub)" <gi...@apache.org>.
hainenber merged PR #40706:
URL: https://github.com/apache/superset/pull/40706
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [PR] fix: correct typos in config.py and models_test.py comments [superset]
Posted by "bito-code-review[bot] (via GitHub)" <gi...@apache.org>.
bito-code-review[bot] commented on PR #40706:
URL: https://github.com/apache/superset/pull/40706#issuecomment-4611573539
AI Code Review is in progress (usually takes 3 to 15 minutes unless it's a very large PR).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org