[GitHub] [tvm] gromero commented on pull request #8738: [microTVM][RVM] Improve base-box-tool 'build' command

[GitBox <gi...@apache.org>]

gromero commented on pull request #8738:
URL: https://github.com/apache/tvm/pull/8738#issuecomment-989066488


   @areusch I've rebased it since I still think it's a valid fix. Just to quickly recap:
   
   Currently we have this behavior:
   
   ```
   gromero@amd:~/git/tvm/apps/microtvm/reference-vm$ python3 ./base-box-tool.py --provider virtualbox build zephyr
   virtualbox: output will be in this color.
   
   Build 'virtualbox' errored after 33 milliseconds 196 microseconds: Output directory exists: output-packer-virtualbox
   
   Use the force flag to delete it prior to building.
   
   ==> Wait completed after 33 milliseconds 225 microseconds
   
   ==> Some builds didn't complete successfully and had errors:
   --> virtualbox: Output directory exists: output-packer-virtualbox
   
   Use the force flag to delete it prior to building.
   
   ==> Builds finished but no artifacts were created.
   Traceback (most recent call last):
     File "/home/gromero/git/tvm/apps/microtvm/reference-vm/./base-box-tool.py", line 577, in <module>
       main()
     File "/home/gromero/git/tvm/apps/microtvm/reference-vm/./base-box-tool.py", line 573, in main
       args.func(args)
     File "/home/gromero/git/tvm/apps/microtvm/reference-vm/./base-box-tool.py", line 266, in build_command
       subprocess.check_call(
     File "/usr/lib/python3.9/subprocess.py", line 373, in check_call
       raise CalledProcessError(retcode, cmd)
   subprocess.CalledProcessError: Command '['packer', 'build', 'packer.json']' returned non-zero exit status 1.
   gromero@amd:~/git/tvm/apps/microtvm/reference-vm$ 
   ```
   
   With the change in this PR applied it turn into the following behavior:
   
   ```
   gromero@amd:~/git/tvm/apps/microtvm/reference-vm$ python3 ./base-box-tool.py --provider virtualbox build zephyr
   A box package /home/gromero/git/tvm/apps/microtvm/reference-vm/zephyr/base-box/output-packer-virtualbox already exists. Refusing to overwrite it!
   One or more box packages exist (see list above). To rebuild use '--force'
   gromero@amd:~/git/tvm/apps/microtvm/reference-vm$
   ```
   I still think it `--force` should trust `packer ... -force` to remove it, but let me know if you objects to it and I'm happy to change it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org