You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dtenedor (via GitHub)" <gi...@apache.org> on 2023/04/05 20:58:41 UTC
[GitHub] [spark] dtenedor commented on a diff in pull request #40662: [SPARK-43030][SQL] Deduplicate relations with metadata columns
dtenedor commented on code in PR #40662:
URL: https://github.com/apache/spark/pull/40662#discussion_r1159017263
##########
sql/core/src/test/resources/sql-tests/analyzer-results/subquery/in-subquery/in-with-cte.sql.out:
##########
@@ -198,23 +198,20 @@ WithCTE
: : : : +- Filter (cast(t1b#x as int) > 0)
: : : : +- SubqueryAlias cte1
: : : : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
- : : : +- Project [t1b#x AS t1b#x]
- : : : +- Project [t1b#x]
- : : : +- Filter (cast(t1b#x as int) > 5)
- : : : +- SubqueryAlias cte1
- : : : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
- : : +- Project [t1b#x AS t1b#x]
- : : +- Intersect false
- : : :- Project [t1b#x]
- : : : +- SubqueryAlias cte1
- : : : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
- : : +- Project [t1b#x]
- : : +- SubqueryAlias cte1
- : : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
- : +- Project [t1b#x AS t1b#x]
- : +- Project [t1b#x]
- : +- SubqueryAlias cte1
- : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
+ : : : +- Project [t1b#x]
+ : : : +- Filter (cast(t1b#x as int) > 5)
+ : : : +- SubqueryAlias cte1
+ : : : +- CTERelationRef xxxx, true, [t1a#x, t1b#x]
Review Comment:
Sounds good. Do you think this test is sufficient to cover the change? Should we try to add more CTE tests with different duplicates? (I am not sure of the answer, just asking the question.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org