You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@solr.apache.org by ho...@apache.org on 2024/07/12 21:00:53 UTC
(solr) branch main updated: SOLR-10654: PrometheusResponseWriter test tweaks
This is an automated email from the ASF dual-hosted git repository.
hossman pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/solr.git
The following commit(s) were added to refs/heads/main by this push:
new 6967c7b695c SOLR-10654: PrometheusResponseWriter test tweaks
6967c7b695c is described below
commit 6967c7b695c39b045e1ac49eb346ab49ceab2a13
Author: Chris Hostetter <ho...@apache.org>
AuthorDate: Fri Jul 12 14:00:40 2024 -0700
SOLR-10654: PrometheusResponseWriter test tweaks
- Fix MetricsHandlerTest
- AwaitsFix TestPrometheusResponseWriter pending SOLR-17368
---
.../core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java | 2 +-
.../src/test/org/apache/solr/response/TestPrometheusResponseWriter.java | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java b/solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java
index 217c07433e4..6fc0f697105 100644
--- a/solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java
+++ b/solr/core/src/test/org/apache/solr/handler/admin/MetricsHandlerTest.java
@@ -922,7 +922,7 @@ public class MetricsHandlerTest extends SolrTestCaseJ4 {
actualGaugeDataPoint =
getGaugeDatapointSnapshot(
actualSnapshot, Labels.of("item", "committed", "space", "CodeHeap-'non-nmethods'"));
- assertEquals(0, actualGaugeDataPoint.getValue(), 0);
+ assertNotNull(actualGaugeDataPoint);
actualSnapshot = getMetricSnapshot(actualSnapshots, "solr_metrics_jvm_buffers");
actualGaugeDataPoint =
diff --git a/solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java b/solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java
index f46f5a0f85d..c183a2610f6 100644
--- a/solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java
+++ b/solr/core/src/test/org/apache/solr/response/TestPrometheusResponseWriter.java
@@ -35,6 +35,7 @@ import org.junit.ClassRule;
import org.junit.Test;
/** Tests the {@link PrometheusResponseWriter} behavior */
+@LuceneTestCase.AwaitsFix(bugUrl = "https://issues.apache.org/jira/browse/SOLR-17368")
public class TestPrometheusResponseWriter extends SolrTestCaseJ4 {
@ClassRule public static SolrJettyTestRule solrClientTestRule = new SolrJettyTestRule();