You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by "gianm (via GitHub)" <gi...@apache.org> on 2025/04/14 20:45:06 UTC
[PR] HavingSpecMetricComparator: Return -1 when finalized metric is null. (druid)
gianm opened a new pull request, #17911:
URL: https://github.com/apache/druid/pull/17911
This patch encodes an assumption around nulls-first ordering, rather than branching into the "custom type" code path. Fixes a bug where equalTo, greaterThan, and lessThan having specs would throw null-pointer exceptions when used with first/last aggregators that return nulls.
This patch also switches error handling to DruidException and adds defensive checks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
Re: [PR] HavingSpecMetricComparator: Return -1 when finalized metric is null. (druid)
Posted by "cryptoe (via GitHub)" <gi...@apache.org>.
cryptoe merged PR #17911:
URL: https://github.com/apache/druid/pull/17911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org