[GitHub] jtulach commented on a change in pull request #1064: Snapshot of APIs as of release 10.0

[GitBox <gi...@apache.org>]

jtulach commented on a change in pull request #1064: Snapshot of APIs as of release 10.0
URL: https://github.com/apache/incubator-netbeans/pull/1064#discussion_r244659441
 
 

 ##########
 File path: nbbuild/build.xml
 ##########
 @@ -1776,22 +1776,15 @@ It is possible to use -Ddebug.port=3234 -Ddebug.pause=y to start the system in d
     </subant>
   </target>
 
-  <target name="gen-sigtests-release" depends="bootstrap"
+  <target name="gen-sigtests-release" depends="init"
     description="Generates signature files into stable API modules directories"
   >
     <echo message="Generating signature files into stable API modules directories"/>
 
-    <pathconvert property="modules.fullpath" >
 
 Review comment:
   ## All the APIs
   
   This change has one, interesting side effect. The `.sig` files are now added to every module with some `OpenIDE-Module-Public-Packages`. Btw. that is the reason why there is so many new files added.
   
   As a consequence we now have the same safety net for developing APIs all over the NetBeans code base. E.g. when we make an incompatible change in some APIs, we get a warning (as a failed travis or even local build) and we can take corrective actions.
   
   ## Solving the friend dependency problem!?
   
   With such infrastructure in place I wouldn't be afraid to open up (step by step and case by case) more modules with *friend dependencies* to public. Their API is still going to lack documentation, but if we open them and classify as *under development*, then at least our fellow developers will not have to play wild tricks to use them. Moreover, we'll be able to guarantee backward compatibility with released Apache NetBeans versions thanks to having the [SigTest](https://github.com/jtulach/netbeans-apitest) check in place.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists