You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2022/03/30 08:12:33 UTC

[GitHub] [dubbo] yangtao1987625 opened a new issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

yangtao1987625 opened a new issue #9863:
URL: https://github.com/apache/dubbo/issues/9863


   ### Environment
   
   * Dubbo version: 3.0.2
   * Operating System version: win7
   * Java version: 1.8
   
   ### Steps to reproduce this issue
   
   注解如下:
   @DubboReference(async = true, methods = {@Method(name = "xxx", isReturn = false)})
   
   查看代码发现:
   ReferenceCreator :: createMethodConfig方法中mcDataBinder.bind(propertyValues) 这里绑定不上"isReturn"属性
   
   原因如下:
   底层代码会生成一个MethodConfig的BeanInfo对象,然后会校验属性是否在这个BeanInfo的属性集中,如果不在会被过滤掉
   
   然而用如下代码做测试:
   Class beanClass = Class.forName("org.apache.dubbo.config.MethodConfig");
   BeanInfo beanInfo = Introspector.getBeanInfo(beanClass);
   
   此时发现beanInfo中的属性集中没有"isReturn"属性,只有"return"属性,所以isReturn属性在绑定时被过滤掉了
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] yangtao1987625 commented on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
yangtao1987625 commented on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1085662271


   MethodConfig中isReturn属性改成return就可以解决吧?
   例如该类中的retry就可以成功绑定


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] wangchengming666 removed a comment on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
wangchengming666 removed a comment on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1083015735


   i’ll fix it


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] yangtao1987625 removed a comment on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
yangtao1987625 removed a comment on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1085686087


   > i’ll fix it
   
   是不是直接MethodConfig中 `private Boolean isReturn;`  改成 `private Boolean return;`  也可以修复这个BUG?就跟retry属性类似,是可以绑定成功的
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] yangtao1987625 commented on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
yangtao1987625 commented on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1085686087


   > i’ll fix it
   
   是不是直接MethodConfig中 `private Boolean isReturn;`  改成 `private Boolean return;`  也可以修复这个BUG?就跟retry属性类似,是可以绑定成功的
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] yangtao1987625 commented on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
yangtao1987625 commented on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1083019491


   > i’ll fix it
   
   good job


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] wangchengming666 commented on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
wangchengming666 commented on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1083015735






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org


[GitHub] [dubbo] yangtao1987625 removed a comment on issue #9863: 使用oneway通信时,@Method注解中的isReturn不生效

Posted by GitBox <gi...@apache.org>.
yangtao1987625 removed a comment on issue #9863:
URL: https://github.com/apache/dubbo/issues/9863#issuecomment-1085662271


   MethodConfig中isReturn属性改成return就可以解决吧?
   例如该类中的retry就可以成功绑定


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org