[GitHub] [submarine] pingsutw commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.

[GitBox <gi...@apache.org>]

pingsutw commented on a change in pull request #117: SUBMARINE-303. Submarine client submit job to submarine server by grpc.
URL: https://github.com/apache/submarine/pull/117#discussion_r352260441
 
 

 ##########
 File path: dev-support/mini-submarine/conf/bootstrap.sh
 ##########
 @@ -36,6 +36,16 @@ for f in slaves core-site.xml hdfs-site.xml mapred-site.xml yarn-site.xml contai
   fi
 done
 
+# Copy submarine config
+for f in slaves submarine-site.xml submarine-env.sh; do
+  if [[ -e ${CONFIG_DIR}/$f ]]; then
+    cp ${CONFIG_DIR}/$f /opt/submarine-current/conf/$f
 
 Review comment:
   `/opt/submarine-current/conf/`  already has latest submarine config, I think we could remove **submarine-site.xml** and **submarine-env.sh** in `dev-support/mini-submarine/conf/`, so when submarine config change we don't need to update config in mini-submarine as well

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@submarine.apache.org
For additional commands, e-mail: dev-help@submarine.apache.org