You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/16 06:44:29 UTC

[GitHub] [apisix-dashboard] LiteSun commented on a change in pull request #1983: fix: only auth type plugin need to configure

LiteSun commented on a change in pull request #1983:
URL: https://github.com/apache/apisix-dashboard/pull/1983#discussion_r671005397



##########
File path: web/src/components/Plugin/service.ts
##########
@@ -34,6 +34,7 @@ export const fetchList = () => {
     const typedData = data.data.map(item => ({
       ...item,
       type: PLUGIN_LIST[item.name]?.type || "other",

Review comment:
        > Does type props still be used? If not we can delete it ^^
   
   Type props still are used.
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org