You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Uwe Schindler (JIRA)" <ji...@apache.org> on 2015/03/18 00:21:38 UTC
[jira] [Comment Edited] (SOLR-7258) Forbid MessageFormat.format and
MessageFormat single-arg constructor
[ https://issues.apache.org/jira/browse/SOLR-7258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14366289#comment-14366289 ]
Uwe Schindler edited comment on SOLR-7258 at 3/17/15 11:20 PM:
---------------------------------------------------------------
Hi Shalin,
can you open an issue at forbidden-apis? It would be good to get the signatures into the unsafe signatures there.
If you like you can send a pull request :-) https://github.com/policeman-tools/forbidden-apis
Thanks, Uwe
was (Author: thetaphi):
Hi Shalin,
can you open an issue at forbidden-apis? It would be good to get the signatures into the unsafe signatures there.
Thanks, Uwe
> Forbid MessageFormat.format and MessageFormat single-arg constructor
> --------------------------------------------------------------------
>
> Key: SOLR-7258
> URL: https://issues.apache.org/jira/browse/SOLR-7258
> Project: Solr
> Issue Type: Task
> Reporter: Shalin Shekhar Mangar
> Assignee: Shalin Shekhar Mangar
> Fix For: Trunk, 5.1
>
> Attachments: SOLR-7258.patch, SOLR-7258.patch
>
>
> While tracing some TestBlobHandler failures with the thai locale I found that the problem was MessageFormat.format which when given a Number ultimately executes NumberFormat.getInstance(getLocale()).format(argument). In thai locale, this transforms the digit 1 to a thai character and hence fails the test.
> We should audit all usages of MessageFormat.format to see if any Number objects are being passed as argument and wrap them with String.valueOf().
> Edit - Actually most format operations use the default locale so we should just ban this API outright.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org