You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by sandeep samudrala <sa...@gmail.com> on 2015/09/03 12:41:54 UTC
Review Request 38096: Entity submit fails when multiple threads try
submitting same definition
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1410
https://issues.apache.org/jira/browse/FALCON-1410
Repository: falcon-git
Description
-------
Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
Diffs
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
Diff: https://reviews.apache.org/r/38096/diff/
Testing
-------
Thanks,
sandeep samudrala
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/#review97725
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 315)
<https://reviews.apache.org/r/38096/#comment153734>
We can just have one obtainEntityLocks method. The same can be used for both updates and submit.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 321)
<https://reviews.apache.org/r/38096/#comment153735>
Add a Null check for entities that don't have dependents.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 335)
<https://reviews.apache.org/r/38096/#comment153736>
As mentioned above, merge it with a single method.
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 347)
<https://reviews.apache.org/r/38096/#comment153737>
Rename this to "releaseEntityLocks"
- Pallavi Rao
On Sept. 3, 2015, 12:15 p.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38096/
> -----------------------------------------------------------
>
> (Updated Sept. 3, 2015, 12:15 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1410
> https://issues.apache.org/jira/browse/FALCON-1410
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
>
> Diff: https://reviews.apache.org/r/38096/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/#review97730
-----------------------------------------------------------
Ship it!
Ship It!
- Pallavi Rao
On Sept. 4, 2015, 6:21 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38096/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1410
> https://issues.apache.org/jira/browse/FALCON-1410
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
>
> Diff: https://reviews.apache.org/r/38096/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/#review97736
-----------------------------------------------------------
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java (line 331)
<https://reviews.apache.org/r/38096/#comment153748>
Can you please add a debug log here also - capturing the main entity and the dependent entity which we have acquired lock on.
Are the locks not required for delete operation just like update and submit?
- Ajay Yadava
On Sept. 4, 2015, 6:21 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38096/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 6:21 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1410
> https://issues.apache.org/jira/browse/FALCON-1410
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
>
> Diff: https://reviews.apache.org/r/38096/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/#review97897
-----------------------------------------------------------
Ship it!
Ship It!
- Ajay Yadava
On Sept. 4, 2015, 10:30 a.m., sandeep samudrala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38096/
> -----------------------------------------------------------
>
> (Updated Sept. 4, 2015, 10:30 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1410
> https://issues.apache.org/jira/browse/FALCON-1410
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
>
>
> Diffs
> -----
>
> prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 9700baa
> webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
> webapp/src/test/java/org/apache/falcon/resource/TestContext.java 4a25b88
>
> Diff: https://reviews.apache.org/r/38096/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> sandeep samudrala
>
>
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 10:30 a.m.)
Review request for Falcon.
Bugs: FALCON-1410
https://issues.apache.org/jira/browse/FALCON-1410
Repository: falcon-git
Description
-------
Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 9700baa
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
webapp/src/test/java/org/apache/falcon/resource/TestContext.java 4a25b88
Diff: https://reviews.apache.org/r/38096/diff/
Testing
-------
Thanks,
sandeep samudrala
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/
-----------------------------------------------------------
(Updated Sept. 4, 2015, 6:21 a.m.)
Review request for Falcon.
Bugs: FALCON-1410
https://issues.apache.org/jira/browse/FALCON-1410
Repository: falcon-git
Description
-------
Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
Diff: https://reviews.apache.org/r/38096/diff/
Testing
-------
Thanks,
sandeep samudrala
Re: Review Request 38096: Entity submit fails when multiple threads
try submitting same definition
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38096/
-----------------------------------------------------------
(Updated Sept. 3, 2015, 12:15 p.m.)
Review request for Falcon.
Bugs: FALCON-1410
https://issues.apache.org/jira/browse/FALCON-1410
Repository: falcon-git
Description
-------
Acquired lock on the entity that is getting submitted and failing any other parallel submission upon lock already being acquired.
Diffs (updated)
-----
prism/src/main/java/org/apache/falcon/resource/AbstractEntityManager.java 78964dd
webapp/src/test/java/org/apache/falcon/resource/EntityManagerJerseyIT.java f0cee61
Diff: https://reviews.apache.org/r/38096/diff/
Testing
-------
Thanks,
sandeep samudrala