You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Aleksandr Kovalenko <ak...@hortonworks.com> on 2014/10/17 20:23:12 UTC
Review Request 26883: Slider View: Show slider-view user beside the
Create App page
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26883/
-----------------------------------------------------------
Review request for Ambari, Alexandr Antonenko and Srimanth Gunturi.
Bugs: AMBARI-7841
https://issues.apache.org/jira/browse/AMBARI-7841
Repository: ambari
Description
-------
On the Slider Apps table page we need to show the user that is using this view. On the left side of the Create App we need to show the user. It should look like "[user-icon] username".
The "username" can be got from the /api/v1/views/SLIDER/versions/1.0.0/instances/s1 call's ViewInstanceInfo/properties/slider.user value.
Diffs
-----
contrib/views/slider/src/main/resources/ui/app/controllers/slider_controller.js e4476fd
contrib/views/slider/src/main/resources/ui/app/styles/app.less ddff96a
contrib/views/slider/src/main/resources/ui/app/templates/application.hbs 7961387
contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js f5d556a
contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step3_controller_test.js 56346b2
contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0faec95
Diff: https://reviews.apache.org/r/26883/diff/
Testing
-------
Tests completed in 7120 milliseconds.
124 assertions of 124 passed, 0 failed.
Thanks,
Aleksandr Kovalenko
Re: Review Request 26883: Slider View: Show slider-view user beside
the Create App page
Posted by Alexandr Antonenko <hi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26883/#review57184
-----------------------------------------------------------
Ship it!
Ship It!
- Alexandr Antonenko
On Oct. 17, 2014, 6:23 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26883/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 6:23 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Srimanth Gunturi.
>
>
> Bugs: AMBARI-7841
> https://issues.apache.org/jira/browse/AMBARI-7841
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the Slider Apps table page we need to show the user that is using this view. On the left side of the Create App we need to show the user. It should look like "[user-icon] username".
>
> The "username" can be got from the /api/v1/views/SLIDER/versions/1.0.0/instances/s1 call's ViewInstanceInfo/properties/slider.user value.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/controllers/slider_controller.js e4476fd
> contrib/views/slider/src/main/resources/ui/app/styles/app.less ddff96a
> contrib/views/slider/src/main/resources/ui/app/templates/application.hbs 7961387
> contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js f5d556a
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step3_controller_test.js 56346b2
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0faec95
>
> Diff: https://reviews.apache.org/r/26883/diff/
>
>
> Testing
> -------
>
> Tests completed in 7120 milliseconds.
> 124 assertions of 124 passed, 0 failed.
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>
Re: Review Request 26883: Slider View: Show slider-view user beside
the Create App page
Posted by Srimanth Gunturi <sr...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/26883/#review57183
-----------------------------------------------------------
Ship it!
Ship It!
- Srimanth Gunturi
On Oct. 17, 2014, 6:23 p.m., Aleksandr Kovalenko wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/26883/
> -----------------------------------------------------------
>
> (Updated Oct. 17, 2014, 6:23 p.m.)
>
>
> Review request for Ambari, Alexandr Antonenko and Srimanth Gunturi.
>
>
> Bugs: AMBARI-7841
> https://issues.apache.org/jira/browse/AMBARI-7841
>
>
> Repository: ambari
>
>
> Description
> -------
>
> On the Slider Apps table page we need to show the user that is using this view. On the left side of the Create App we need to show the user. It should look like "[user-icon] username".
>
> The "username" can be got from the /api/v1/views/SLIDER/versions/1.0.0/instances/s1 call's ViewInstanceInfo/properties/slider.user value.
>
>
> Diffs
> -----
>
> contrib/views/slider/src/main/resources/ui/app/controllers/slider_controller.js e4476fd
> contrib/views/slider/src/main/resources/ui/app/styles/app.less ddff96a
> contrib/views/slider/src/main/resources/ui/app/templates/application.hbs 7961387
> contrib/views/slider/src/main/resources/ui/test/integration/pages/index_test.js f5d556a
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/createAppWizard/step3_controller_test.js 56346b2
> contrib/views/slider/src/main/resources/ui/test/unit/controllers/slider_controller_test.js 0faec95
>
> Diff: https://reviews.apache.org/r/26883/diff/
>
>
> Testing
> -------
>
> Tests completed in 7120 milliseconds.
> 124 assertions of 124 passed, 0 failed.
>
>
> Thanks,
>
> Aleksandr Kovalenko
>
>