You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/01/04 16:22:33 UTC
[GitHub] [incubator-superset] codecov-io edited a comment on pull request #12171: refactor: Sync Scoping tree with Forms data
codecov-io edited a comment on pull request #12171:
URL: https://github.com/apache/incubator-superset/pull/12171#issuecomment-749470100
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=h1) Report
> Merging [#12171](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=desc) (a5c3467) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ba952ba39df47dfd32633fd4b5cf23e7ec5b40b9?el=desc) (ba952ba) will **decrease** coverage by `3.20%`.
> The diff coverage is `66.96%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #12171 +/- ##
==========================================
- Coverage 66.31% 63.10% -3.21%
==========================================
Files 994 997 +3
Lines 49033 49289 +256
Branches 4977 5002 +25
==========================================
- Hits 32515 31106 -1409
- Misses 16373 17982 +1609
- Partials 145 201 +56
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| javascript | `61.22% <66.96%> (-0.01%)` | :arrow_down: |
| python | `64.33% <ø> (+0.11%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset-frontend/src/common/components/index.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbW1vbi9jb21wb25lbnRzL2luZGV4LnRzeA==) | `100.00% <ø> (ø)` | |
| [...ard/components/nativeFilters/FilterConfigModal.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnTW9kYWwudHN4) | `59.50% <0.00%> (-4.08%)` | :arrow_down: |
| [superset-frontend/src/dashboard/reducers/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9yZWR1Y2Vycy90eXBlcy50cw==) | `0.00% <0.00%> (ø)` | |
| [...nd/src/dashboard/components/nativeFilters/utils.ts](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdXRpbHMudHM=) | `54.95% <51.16%> (-2.94%)` | :arrow_down: |
| [...dashboard/components/nativeFilters/FilterScope.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyU2NvcGUudHN4) | `76.00% <76.00%> (ø)` | |
| [...oard/components/nativeFilters/FilterConfigForm.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQ29uZmlnRm9ybS50c3g=) | `85.18% <76.92%> (+3.04%)` | :arrow_up: |
| [...dashboard/components/nativeFilters/ScopingTree.tsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvU2NvcGluZ1RyZWUudHN4) | `81.81% <85.71%> (+4.04%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/state.ts](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvc3RhdGUudHM=) | `65.38% <100.00%> (+4.51%)` | :arrow_up: |
| [...nd/src/dashboard/components/nativeFilters/types.ts](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvdHlwZXMudHM=) | `100.00% <100.00%> (ø)` | |
| [superset-frontend/src/explore/App.jsx](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvQXBwLmpzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [189 more](https://codecov.io/gh/apache/incubator-superset/pull/12171/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=footer). Last update [ba952ba...8de67d8](https://codecov.io/gh/apache/incubator-superset/pull/12171?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org