You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2022/04/08 07:52:09 UTC
[GitHub] [kafka] dajac opened a new pull request, #12015: MINOR: A few code cleanups in DynamicBrokerConfig
dajac opened a new pull request, #12015:
URL: https://github.com/apache/kafka/pull/12015
Made a few edits while reading that file.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] showuon commented on a diff in pull request #12015: MINOR: A few code cleanups in DynamicBrokerConfig
Posted by GitBox <gi...@apache.org>.
showuon commented on code in PR #12015:
URL: https://github.com/apache/kafka/pull/12015#discussion_r846566765
##########
core/src/main/scala/kafka/server/DynamicBrokerConfig.scala:
##########
@@ -868,7 +872,7 @@ object DynamicListenerConfig {
)
}
-class DynamicClientQuotaCallback(brokerId: Int, server: KafkaBroker) extends Reconfigurable {
+class DynamicClientQuotaCallback(server: KafkaBroker) extends Reconfigurable {
Review Comment:
brokerId is unused. Nice clean up.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kafka] dajac merged pull request #12015: MINOR: A few code cleanups in DynamicBrokerConfig
Posted by GitBox <gi...@apache.org>.
dajac merged PR #12015:
URL: https://github.com/apache/kafka/pull/12015
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscribe@kafka.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org