[jira] [Commented] (ZOOKEEPER-2558) Potential memory leak in recordio.c

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ZOOKEEPER-2558?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15469003#comment-15469003 ] 

Hadoop QA commented on ZOOKEEPER-2558:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12827267/ZOOKEEPER-2558.patch
  against trunk revision 1757584.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 2.0.3) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    +1 core tests.  The patch passed core unit tests.

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3394//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3394//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3394//console

This message is automatically generated.

> Potential memory leak in recordio.c
> -----------------------------------
>
>                 Key: ZOOKEEPER-2558
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2558
>             Project: ZooKeeper
>          Issue Type: Bug
>          Components: c client
>    Affects Versions: 3.4.9, 3.5.2
>            Reporter: Michael Han
>            Assignee: Michael Han
>            Priority: Minor
>             Fix For: 3.4.10, 3.5.3
>
>         Attachments: ZOOKEEPER-2558.patch
>
>
> We have code like this in {{create_buffer_iarchive}} and {{create_buffer_oarchive}}:
> {code}
>     struct iarchive *ia = malloc(sizeof(*ia));
>     struct buff_struct *buff = malloc(sizeof(struct buff_struct));
>     if (!ia) return 0;
>     if (!buff) {
>         free(ia);
>         return 0;
>     }
> {code}
> If first malloc failed but second succeeds, then the memory allocated with second malloc will not get freed when the function returned. One could argue that if first malloc failed the second will also fail (i.e. when system run out of memory), but I could also see the possibility of the opposite (the first malloc failed because heap fragmentation but the second succeeds).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)