[GitHub] [flink-connector-pulsar] syhily commented on a diff in pull request #19: [FLINK-30622][Connector/Pulsar] Support consuming messages with schema auto-detection from Pulsar.

[GitBox <gi...@apache.org>]

syhily commented on code in PR #19:
URL: https://github.com/apache/flink-connector-pulsar/pull/19#discussion_r1070491084


##########
flink-connector-pulsar/src/main/java/org/apache/flink/connector/pulsar/source/reader/deserializer/PulsarDeserializationSchema.java:
##########
@@ -19,29 +19,25 @@
 package org.apache.flink.connector.pulsar.source.reader.deserializer;
 
 import org.apache.flink.annotation.PublicEvolving;
-import org.apache.flink.api.common.ExecutionConfig;
 import org.apache.flink.api.common.serialization.DeserializationSchema;
 import org.apache.flink.api.common.serialization.DeserializationSchema.InitializationContext;
-import org.apache.flink.api.common.typeinfo.TypeInformation;
 import org.apache.flink.api.java.typeutils.ResultTypeQueryable;
-import org.apache.flink.connector.pulsar.common.schema.PulsarSchema;
-import org.apache.flink.connector.pulsar.source.PulsarSourceBuilder;
 import org.apache.flink.connector.pulsar.source.config.SourceConfiguration;
 import org.apache.flink.util.Collector;
 
 import org.apache.pulsar.client.api.Message;
 import org.apache.pulsar.client.api.Schema;
-import org.apache.pulsar.common.schema.KeyValue;
 
 import java.io.Serializable;
 
 /**
  * A schema bridge for deserializing the pulsar's {@code Message<byte[]>} into a flink managed
- * instance. We support both the pulsar's self managed schema and flink managed schema.
+ * instance. We support both the pulsar's {@link Schema} and flink's {@link DeserializationSchema}.
  *
  * @param <T> The output message type for sinking to downstream flink operator.
  */
 @PublicEvolving
+@SuppressWarnings("java:S112")

Review Comment:
   This is used for SonarQube plugin in IntelliJ IDEA. Sonar require a specified exception instead of a generic one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org