You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "pepijnve (via GitHub)" <gi...@apache.org> on 2026/07/23 12:10:57 UTC

[PR] Add setter for `TaskContext::task_id` [datafusion]

pepijnve opened a new pull request, #23837:
URL: https://github.com/apache/datafusion/pull/23837

   ## Which issue does this PR close?
   
   Closes #22072
   
   ## Rationale for this change
   
   Without a way to set `TaskContext::task_id` the field is a bit pointless. This MR adds a way to set the field.
   This does not automatically make the field useful for correlation purposes (as hinted at by the linked issue) since it's not filled in anywhere yet, but at least the capability is already there.
   
   ## Are these changes tested?
   
   Not sure how to meaningfully test this
   
   ## Are there any user-facing changes?
   
   No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add setter for `TaskContext::task_id` [datafusion]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #23837:
URL: https://github.com/apache/datafusion/pull/23837#issuecomment-5058464552

   ## [Codecov](https://app.codecov.io/gh/apache/datafusion/pull/23837?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :x: Patch coverage is `0%` with `4 lines` in your changes missing coverage. Please review.
   :white_check_mark: Project coverage is 80.75%. Comparing base ([`1c8295c`](https://app.codecov.io/gh/apache/datafusion/commit/1c8295c992c597a53dcfa01f6dcf1cdc51268adb?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f19c10c`](https://app.codecov.io/gh/apache/datafusion/commit/f19c10c645bdbce56b05dbb8d1fb5149acbc6101?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   
   | [Files with missing lines](https://app.codecov.io/gh/apache/datafusion/pull/23837?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
   |---|---|---|
   | [datafusion/execution/src/task.rs](https://app.codecov.io/gh/apache/datafusion/pull/23837?src=pr&el=tree&filepath=datafusion%2Fexecution%2Fsrc%2Ftask.rs&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZGF0YWZ1c2lvbi9leGVjdXRpb24vc3JjL3Rhc2sucnM=) | 0.00% | [4 Missing :warning: ](https://app.codecov.io/gh/apache/datafusion/pull/23837?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@            Coverage Diff             @@
   ##             main   #23837      +/-   ##
   ==========================================
   - Coverage   80.75%   80.75%   -0.01%     
   ==========================================
     Files        1089     1089              
     Lines      368809   368813       +4     
     Branches   368809   368813       +4     
   ==========================================
   - Hits       297837   297825      -12     
   - Misses      53217    53230      +13     
   - Partials    17755    17758       +3     
   ```
   </details>
   
   [:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/datafusion/pull/23837?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add setter for `TaskContext::task_id` [datafusion]

Posted by "pepijnve (via GitHub)" <gi...@apache.org>.
pepijnve commented on PR #23837:
URL: https://github.com/apache/datafusion/pull/23837#issuecomment-5061054638

   > Thanks @pepijnve makes sense to me Probably going fwd it would be nice to document purposes when the user might need to populate the field, but the PR is good to go
   
   I was just going through old issues. The issue logger's stated reason is correlating log messages. Don't have a need for this myself, but it made sense since the field is already there yet there's not convenient way to set it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org


Re: [PR] Add setter for `TaskContext::task_id` [datafusion]

Posted by "comphead (via GitHub)" <gi...@apache.org>.
comphead merged PR #23837:
URL: https://github.com/apache/datafusion/pull/23837


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org