You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "littleeleventhwolf (via GitHub)" <gi...@apache.org> on 2025/02/08 03:19:27 UTC
[PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
littleeleventhwolf opened a new pull request, #26126:
URL: https://github.com/apache/flink/pull/26126
<!--
*Thank you very much for contributing to Apache Flink - we are happy that you want to help us improve Flink. To help the community review your contribution in the best possible way, please go through the checklist below, which will get the contribution into a shape in which it can be best reviewed.*
*Please understand that we do not do this to make contributions to Flink a hassle. In order to uphold a high standard of quality for code contributions, while at the same time managing a large number of contributions, we need contributors to prepare the contributions well, and give reviewers enough contextual information for the review. Please also understand that contributions that do not follow this guide will take longer to review and thus typically be picked up with lower priority by the community.*
## Contribution Checklist
- Make sure that the pull request corresponds to a [JIRA issue](https://issues.apache.org/jira/projects/FLINK/issues). Exceptions are made for typos in JavaDoc or documentation files, which need no JIRA issue.
- Name the pull request in the form "[FLINK-XXXX] [component] Title of the pull request", where *FLINK-XXXX* should be replaced by the actual issue number. Skip *component* if you are unsure about which is the best component.
Typo fixes that have no associated JIRA issue should be named following this pattern: `[hotfix] [docs] Fix typo in event time introduction` or `[hotfix] [javadocs] Expand JavaDoc for PuncuatedWatermarkGenerator`.
- Fill out the template below to describe the changes contributed by the pull request. That will give reviewers the context they need to do the review.
- Make sure that the change passes the automated tests, i.e., `mvn clean verify` passes. You can set up Azure Pipelines CI to do that following [this guide](https://cwiki.apache.org/confluence/display/FLINK/Azure+Pipelines#AzurePipelines-Tutorial:SettingupAzurePipelinesforaforkoftheFlinkrepository).
- Each pull request should address only one issue, not mix up code from multiple issues.
- Each commit in the pull request has a meaningful commit message (including the JIRA id)
- Once all items of the checklist are addressed, remove the above text and this checklist, leaving only the filled out template below.
**(The sections below can be removed for hotfixes of typos)**
-->
## What is the purpose of the change
Use try-with-resources to close RocksStateKeysIterator and fix some typos.
## Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): (no)
- The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
- The serializers: (no)
- The runtime per-record code paths (performance sensitive): (no)
- Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
- The S3 file system connector: (no)
## Documentation
- Does this pull request introduce a new feature? (no)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1948838156
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
This looks like a good change. The implication is that before this change then managed memory per slot was never being used. I was looking for a unit test of the caller maybe at the ForStSharedResourcesFactory level, to test each of these shared slot options are being honoured and implemented as expected; i.e. checking that the slot memory is being managed or not managed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #26126: [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos.
URL: https://github.com/apache/flink/pull/26126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on PR #26126:
URL: https://github.com/apache/flink/pull/26126#issuecomment-2656442036
Reviewed by Chi on 13/02/2025 Go back to the submitter with review comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1952955606
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
Thanks for the detail. I am not an expert at this area. I assume before the fix SLOT_SHARED_MANAGED would not result in the slot being managed. Now it is working as expected - I was wondering if we could test that this new code is causing the slot to be managed. Are you saying the best way to test this is by testing the owner of the `reservedMemory` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #26126:
URL: https://github.com/apache/flink/pull/26126#issuecomment-2973531731
This PR has been closed since it has not had any activity in 120 days.
If you feel like this was a mistake, or you would like to continue working on it,
please feel free to re-open the PR and ask for a review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "littleeleventhwolf (via GitHub)" <gi...@apache.org>.
littleeleventhwolf commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1954569028
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
No, testing the owner of the `reservedMemory` may not be the most accurate way to determine if the slot is being managed. Instead, we should explore other methods that provide a clearer indication of the slot management status.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "littleeleventhwolf (via GitHub)" <gi...@apache.org>.
littleeleventhwolf commented on PR #26126:
URL: https://github.com/apache/flink/pull/26126#issuecomment-2645735478
@flinkbot run azure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "flinkbot (via GitHub)" <gi...@apache.org>.
flinkbot commented on PR #26126:
URL: https://github.com/apache/flink/pull/26126#issuecomment-2644476318
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "5f351decf79377e3f30b45776729bb87ff629663",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "5f351decf79377e3f30b45776729bb87ff629663",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 5f351decf79377e3f30b45776729bb87ff629663 UNKNOWN
<details>
<summary>Bot commands</summary>
The @flinkbot bot supports the following commands:
- `@flinkbot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "littleeleventhwolf (via GitHub)" <gi...@apache.org>.
littleeleventhwolf commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1950510807
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
The change here ultimately results in `reserveMemory` having different string owner identifiers. What are the deeper implications of this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [hotfix][state/rocksdb] Use try-with-resources to close RocksStateKeysIterator and fix some typos. [flink]
Posted by "davidradl (via GitHub)" <gi...@apache.org>.
davidradl commented on code in PR #26126:
URL: https://github.com/apache/flink/pull/26126#discussion_r1952955606
##########
flink-state-backends/flink-statebackend-rocksdb/src/main/java/org/apache/flink/state/rocksdb/RocksDBSharedResourcesFactory.java:
##########
@@ -36,7 +36,7 @@
*/
enum RocksDBSharedResourcesFactory {
/** Memory allocated per Slot (shared across slot tasks), managed by Flink. */
- SLOT_SHARED_MANAGED(false, MemoryShareScope.SLOT) {
+ SLOT_SHARED_MANAGED(true, MemoryShareScope.SLOT) {
Review Comment:
Thanks for the detail. I am not an expert at this area. I assume before the fix SLOT_SHARED_MANAGED would not result in the slot being managed. Now it is working as expected - I was wondering if we could test 2that this new code is causing the slot to be managed. Are you saying the best way to test this is by testing the owner of the `reservedMemory` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org