[GitHub] [spark] maropu commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison

[GitBox <gi...@apache.org>]

maropu commented on a change in pull request #25055: [SPARK-28189][SQL] Use semanticEquals in Dataset drop method for attributes comparison
URL: https://github.com/apache/spark/pull/25055#discussion_r300848654
 
 

 ##########
 File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
 ##########
 @@ -2322,7 +2322,7 @@ class Dataset[T] private[sql](
     }
     val attrs = this.logicalPlan.output
     val colsAfterDrop = attrs.filter { attr =>
-      attr != expression
+      !attr.semanticEquals(expression)
 
 Review comment:
   ok, thanks. I think its ok to only target dataset.drop in this pr.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org