[GitHub] [camel-karavan] mgubaidullin commented on a change in pull request #206: Support for windows vscode

[GitBox <gi...@apache.org>]

mgubaidullin commented on a change in pull request #206:
URL: https://github.com/apache/camel-karavan/pull/206#discussion_r817888888



##########
File path: karavan-vscode/src/extension.ts
##########
@@ -136,8 +136,8 @@ function openKaravanWebView(context: vscode.ExtensionContext, webviewContent: st
                     if (vscode.workspace.workspaceFolders) {
                         console.log(message);
                         const uriFolder: vscode.Uri = vscode.workspace.workspaceFolders[0].uri;
-                        const uriFile: vscode.Uri = vscode.Uri.file(path.join(uriFolder.path, message.relativePath));
-                        fs.writeFile(uriFile.path, message.yaml, err => {
+                        const uriFile: vscode.Uri = vscode.Uri.file(path.join(uriFolder.path, message.filename));

Review comment:
       Here should be relativePath. Otherwise it won't work when YAML file is in sub folders.
   @arnouthoebreckx could you please test this case.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org