You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "David Capwell (Jira)" <ji...@apache.org> on 2022/11/28 23:32:00 UTC
[jira] [Comment Edited] (CASSANDRA-18077) Add SpotBugs to the build
[ https://issues.apache.org/jira/browse/CASSANDRA-18077?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17640297#comment-17640297 ]
David Capwell edited comment on CASSANDRA-18077 at 11/28/22 11:31 PM:
----------------------------------------------------------------------
[~e.dimitrova] [~mck] would you mind reviewing?
Currently the new tasks fail as more bugs are detected, I wanted to get feedback before going too far as the patch was already large to deal with.
Attached a sample result from trunk: https://issues.apache.org/jira/secure/attachment/13053250/spotbugs.html
was (Author: dcapwell):
[~e.dimitrova] [~mck] would you mind reviewing?
Currently the new tasks fail as more bugs are detected, I wanted to get feedback before going too far as the patch was already large to deal with.
> Add SpotBugs to the build
> -------------------------
>
> Key: CASSANDRA-18077
> URL: https://issues.apache.org/jira/browse/CASSANDRA-18077
> Project: Cassandra
> Issue Type: Improvement
> Components: Build, CI
> Reporter: David Capwell
> Assignee: David Capwell
> Priority: Normal
> Fix For: NA
>
> Attachments: spotbugs.html
>
>
> When working on CASSANDRA-17178 I found that several classes were being reported by the Simulator for not defining serializer version when they are Serializable; this may cause issues for the Simulator so felt it would be best to detect these earlier on before merging new ones.
> SpotBugs has a large set of checks, some more valuable than others for the project; so we should maintain a curated list of issues to fail the build on, and others to warn on.
> This topic was discussed in the following mail threads:
> * Should we add?: https://lists.apache.org/thread/1ro1mvkpvt4vr24nw7dbpdlxo82mq3hz
> * Should we fix UTF-8 issues? https://lists.apache.org/thread/sokxf46s7hyoxr9q4wm7dv3q2nm19nt3
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org