You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@drill.apache.org by Parth Chandra <pc...@maprtech.com> on 2015/03/18 21:35:26 UTC

Review Request 32214: DRILL-2442: C++ client support for impersonation

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32214/
-----------------------------------------------------------

Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Meng.


Repository: drill-git


Description
-------

Implements a new interface to connect where app can provide a set of user properties. Specifying default schema for the connection is subsumed into this. The previous API is available but deprecated. There is no support for SSL connections at the moment


Diffs
-----

  contrib/native/client/example/querySubmitter.cpp 2b0f000 
  contrib/native/client/src/clientlib/drillClient.cpp 878dad4 
  contrib/native/client/src/clientlib/drillClientImpl.hpp d287bfc 
  contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
  contrib/native/client/src/include/drill/common.hpp e149ed1 
  contrib/native/client/src/include/drill/drillClient.hpp 19fec69 

Diff: https://reviews.apache.org/r/32214/diff/


Testing
-------

Usual test queries on MAc/Linux/Win64


Thanks,

Parth Chandra

Re: Review Request 32214: DRILL-2442: C++ client support for impersonation

Posted by Parth Chandra <pc...@maprtech.com>.


> On March 20, 2015, 8:45 p.m., Norris Lee wrote:
> > What happens if you execute a query against a view you don't have access to?

The server will return an error. The client will handle it just like any other error.


- Parth


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32214/#review77272
-----------------------------------------------------------


On March 18, 2015, 8:35 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32214/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 8:35 p.m.)
> 
> 
> Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Meng.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Implements a new interface to connect where app can provide a set of user properties. Specifying default schema for the connection is subsumed into this. The previous API is available but deprecated. There is no support for SSL connections at the moment
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/example/querySubmitter.cpp 2b0f000 
>   contrib/native/client/src/clientlib/drillClient.cpp 878dad4 
>   contrib/native/client/src/clientlib/drillClientImpl.hpp d287bfc 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
>   contrib/native/client/src/include/drill/common.hpp e149ed1 
>   contrib/native/client/src/include/drill/drillClient.hpp 19fec69 
> 
> Diff: https://reviews.apache.org/r/32214/diff/
> 
> 
> Testing
> -------
> 
> Usual test queries on MAc/Linux/Win64
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>

Re: Review Request 32214: DRILL-2442: C++ client support for impersonation

Posted by Norris Lee <no...@simba.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32214/#review77272
-----------------------------------------------------------


What happens if you execute a query against a view you don't have access to?

- Norris Lee


On March 18, 2015, 8:35 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32214/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 8:35 p.m.)
> 
> 
> Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Meng.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Implements a new interface to connect where app can provide a set of user properties. Specifying default schema for the connection is subsumed into this. The previous API is available but deprecated. There is no support for SSL connections at the moment
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/example/querySubmitter.cpp 2b0f000 
>   contrib/native/client/src/clientlib/drillClient.cpp 878dad4 
>   contrib/native/client/src/clientlib/drillClientImpl.hpp d287bfc 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
>   contrib/native/client/src/include/drill/common.hpp e149ed1 
>   contrib/native/client/src/include/drill/drillClient.hpp 19fec69 
> 
> Diff: https://reviews.apache.org/r/32214/diff/
> 
> 
> Testing
> -------
> 
> Usual test queries on MAc/Linux/Win64
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>

Re: Review Request 32214: DRILL-2442: C++ client support for impersonation

Posted by Mehant Baid <ba...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/32214/#review77579
-----------------------------------------------------------

Ship it!


Ship It!

- Mehant Baid


On March 18, 2015, 8:35 p.m., Parth Chandra wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/32214/
> -----------------------------------------------------------
> 
> (Updated March 18, 2015, 8:35 p.m.)
> 
> 
> Review request for drill, Alexander zarei, Mehant Baid, Norris Lee, and Xiao Meng.
> 
> 
> Repository: drill-git
> 
> 
> Description
> -------
> 
> Implements a new interface to connect where app can provide a set of user properties. Specifying default schema for the connection is subsumed into this. The previous API is available but deprecated. There is no support for SSL connections at the moment
> 
> 
> Diffs
> -----
> 
>   contrib/native/client/example/querySubmitter.cpp 2b0f000 
>   contrib/native/client/src/clientlib/drillClient.cpp 878dad4 
>   contrib/native/client/src/clientlib/drillClientImpl.hpp d287bfc 
>   contrib/native/client/src/clientlib/drillClientImpl.cpp ea3a7ee 
>   contrib/native/client/src/include/drill/common.hpp e149ed1 
>   contrib/native/client/src/include/drill/drillClient.hpp 19fec69 
> 
> Diff: https://reviews.apache.org/r/32214/diff/
> 
> 
> Testing
> -------
> 
> Usual test queries on MAc/Linux/Win64
> 
> 
> Thanks,
> 
> Parth Chandra
> 
>