[jira] [Commented] (AIRFLOW-4268) Add MsSqlToGoogleCloudStorageOperator

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-4268?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16814546#comment-16814546 ] 

ASF GitHub Bot commented on AIRFLOW-4268:
-----------------------------------------

Tomme commented on pull request #5077: [AIRFLOW-4268] Add MsSqlToGoogleCloudStorageOperator
URL: https://github.com/apache/airflow/pull/5077
 
 
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [x] My PR addresses the following [AIRFLOW-4268](https://issues.apache.org/jira/browse/AIRFLOW-4268) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-4268
   
   ### Description
   
   - [x] Added MsSqlToGoogleCloudStorageOperator using MsSqlHook and GoogleCloudStorageHook.
   
   ### Tests
   
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
     - tests/contrib/operators/test_mssql_to_gcs_operator.py
   
   ### Commits
   
   - [x] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [x] In case of new functionality, my PR adds documentation that describes how to use it.
     - All the public functions and the classes in the PR contain docstrings that explain what it does
     - If you implement backwards incompatible changes, please leave a note in the [Updating.md](https://github.com/apache/airflow/blob/master/UPDATING.md) so we can assign it to a appropriate release
   
   ### Code Quality
   
   - [x] Passes `flake8`
   
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add MsSqlToGoogleCloudStorageOperator
> -------------------------------------
>
>                 Key: AIRFLOW-4268
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-4268
>             Project: Apache Airflow
>          Issue Type: New Feature
>          Components: contrib, operators
>    Affects Versions: 1.10.2
>            Reporter: Thomas Elvey
>            Assignee: Thomas Elvey
>            Priority: Minor
>
> Using both [mysql_to_gcs.py|https://github.com/Tomme/airflow/blob/master/airflow/contrib/operators/mysql_to_gcs.py] and [postgres_to_gcs.py|https://github.com/Tomme/airflow/blob/master/airflow/contrib/operators/postgres_to_gcs_operator.py] as a base I have created a new operator "MsSqlToGoogleCloudStorageOperator" that may be of use and to further expand on Airflow's GCP offering.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)