You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/15 00:26:40 UTC
[GitHub] [airflow] QuinRiva opened a new pull request #11540: JSON serialization of dates fix
QuinRiva opened a new pull request #11540:
URL: https://github.com/apache/airflow/pull/11540
closes: #11370
---
JSON serialization thows errors if date/datetime fields are in the table. Converting those fields to strings before serialization solves this issue.
Additionally add the DATETIME (which is separate to timestamp) as a typemap for converting a field to bigquery. This has the unfortunate side-effect of converting DATE to DATETIME as the MSSQL DBAPI doesn't distinguish between DATE and DATETIME (both type 2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] stale[bot] commented on pull request #11540: JSON serialization of dates fix
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-751239974
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #11540: Support DATE and DATETIME in MSSQLToGCSOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-787558855
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed in 5 days if no further activity occurs. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #11540: JSON serialization of dates fix
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-751293810
Is this something we should finish/merge @ashb/@kaxil ? it looks needed :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] closed pull request #11540: Support DATE and DATETIME in MSSQLToGCSOperator
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #11540:
URL: https://github.com/apache/airflow/pull/11540
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #11540: Support DATE and DATETIME in MSSQLToGCSOperator
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-752978782
@potiuk This is about integration with Google, so looks like we'll have to take care of it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #11540: JSON serialization of dates fix
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-708755642
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, pylint and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/master/docs/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/master/BREEZE.rst) for testing locally, itโs a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better ๐.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil commented on pull request #11540: JSON serialization of dates fix
Posted by GitBox <gi...@apache.org>.
kaxil commented on pull request #11540:
URL: https://github.com/apache/airflow/pull/11540#issuecomment-721445522
Can you please rebase your PR on latest Master since we have applied [Black](https://github.com/apache/airflow/commit/4e8f9cc8d02b29c325b8a5a76b4837671bdf5f68) and [PyUpgrade](https://github.com/apache/airflow/commit/8c42cf1b00c90f0d7f11b8a3a455381de8e003c5) on Master.
It will help if your squash your commits into single commit first so that there are less conflicts.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org