You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/04/07 15:17:43 UTC

[GitHub] [airflow] uranusjr edited a comment on issue #9387: Use enum for task_states/dag_states

uranusjr edited a comment on issue #9387:
URL: https://github.com/apache/airflow/issues/9387#issuecomment-814997968


   I briefly read related source, and it seems to me the main advantage would be to make sure the right values are passed the right value to SQLAlchemy, so `Literal` feels like a better solution. `Enum` may even be a bit awkward in some places, e.g.
   
   https://github.com/apache/airflow/blob/44a6648fd7482f61ca59153f0caaf0b019c5b3fd/airflow/models/dagrun.py#L490


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org