You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Ashish Singh <as...@cloudera.com> on 2016/02/01 22:08:47 UTC
Review Request 43064: SENTRY-1011: Add Kafka binding
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
Review request for sentry and Dapeng Sun.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 3, 2016, 1:20 a.m., Dapeng Sun wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java, line 40
> > <https://reviews.apache.org/r/43064/diff/2/?file=1229884#file1229884line40>
> >
> > I think we have change the type name of Group to "CONSUMERGROUP", could we return resourceTypeName?
Right, but Kafka still refers this as "group". So incoming authorize requests will have "group" as resource, and as we have "consumergroup" as resource in sentry, convert utils converts resource to `KafkaAuthorizable.AuthorizableType.CONSUMERGROUP.name()`. Does it make sense now?
> On Feb. 3, 2016, 1:20 a.m., Dapeng Sun wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 210
> > <https://reviews.apache.org/r/43064/diff/2/?file=1229885#file1229885line210>
> >
> > The KafkaAuthorizer would be run by Kafka service user, if the getLoginUser() will return the Kafka service user, it will not have any authorization for acl operations.
> > I think we can remove the acl operation, if the acl operations is needed at Kafka side, we may need to add shell commands likes SENTRY-399,SENTRY-995
We are planning to use `kafka-acls.sh` that ships with Kafka to allow users to add/remove acls. I do understand that this will require that 'kafka' user has sufficient privilleges in Sentry to be able to create/modify privileges. Shouldn't that problem be solved by adding 'kafka' user as super user in sentry. How does 'hive' create/modify/delete permissions?
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review117341
-----------------------------------------------------------
On Feb. 2, 2016, 7:12 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 2, 2016, 7:12 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 3, 2016, 1:20 a.m., Dapeng Sun wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 210
> > <https://reviews.apache.org/r/43064/diff/2/?file=1229885#file1229885line210>
> >
> > The KafkaAuthorizer would be run by Kafka service user, if the getLoginUser() will return the Kafka service user, it will not have any authorization for acl operations.
> > I think we can remove the acl operation, if the acl operations is needed at Kafka side, we may need to add shell commands likes SENTRY-399,SENTRY-995
>
> Ashish Singh wrote:
> We are planning to use `kafka-acls.sh` that ships with Kafka to allow users to add/remove acls. I do understand that this will require that 'kafka' user has sufficient privilleges in Sentry to be able to create/modify privileges. Shouldn't that problem be solved by adding 'kafka' user as super user in sentry. How does 'hive' create/modify/delete permissions?
Dapeng, I have removed acls' CRUD implementations and filed KAFKA-3221 and SENTRY-1057 to track implementation of acls' CRUD. Till then we can rely on Sentry CLI.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review117341
-----------------------------------------------------------
On Feb. 8, 2016, 11:30 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 11:30 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Dapeng Sun <da...@intel.com>.
> On 二月 3, 2016, 9:20 a.m., Dapeng Sun wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 210
> > <https://reviews.apache.org/r/43064/diff/2/?file=1229885#file1229885line210>
> >
> > The KafkaAuthorizer would be run by Kafka service user, if the getLoginUser() will return the Kafka service user, it will not have any authorization for acl operations.
> > I think we can remove the acl operation, if the acl operations is needed at Kafka side, we may need to add shell commands likes SENTRY-399,SENTRY-995
>
> Ashish Singh wrote:
> We are planning to use `kafka-acls.sh` that ships with Kafka to allow users to add/remove acls. I do understand that this will require that 'kafka' user has sufficient privilleges in Sentry to be able to create/modify privileges. Shouldn't that problem be solved by adding 'kafka' user as super user in sentry. How does 'hive' create/modify/delete permissions?
>
> Ashish Singh wrote:
> Dapeng, I have removed acls' CRUD implementations and filed KAFKA-3221 and SENTRY-1057 to track implementation of acls' CRUD. Till then we can rely on Sentry CLI.
Thank Ashish. It should be okay.
I think Sentry CLI isn't the only solution, Sentry thrift client also could work. Some UI tools,likes HUE, may have the ablity to integrate with Sentry thrift client.
- Dapeng
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review117341
-----------------------------------------------------------
On 二月 9, 2016, 7:30 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated 二月 9, 2016, 7:30 a.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Dapeng Sun <da...@intel.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review117341
-----------------------------------------------------------
Thank you for your patch, I left some comments below.
sentry-binding/sentry-binding-kafka/pom.xml (line 74)
<https://reviews.apache.org/r/43064/#comment178495>
The version should be added to dependencyManagement in {project dir}/pom.xml
sentry-binding/sentry-binding-kafka/pom.xml (line 79)
<https://reviews.apache.org/r/43064/#comment178496>
The version should be added to dependencyManagement in {project dir}/pom.xml
sentry-binding/sentry-binding-kafka/pom.xml (line 74)
<https://reviews.apache.org/r/43064/#comment178745>
The version should be added to dependencyManagement in {project dir}/pom.xml
sentry-binding/sentry-binding-kafka/pom.xml (line 79)
<https://reviews.apache.org/r/43064/#comment178746>
The version should be added to dependencyManagement in {project dir}/pom.xml
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java (line 40)
<https://reviews.apache.org/r/43064/#comment178747>
I think we have change the type name of Group to "CONSUMERGROUP", could we return resourceTypeName?
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java (line 210)
<https://reviews.apache.org/r/43064/#comment178754>
The KafkaAuthorizer would be run by Kafka service user, if the getLoginUser() will return the Kafka service user, it will not have any authorization for acl operations.
I think we can remove the acl operation, if the acl operations is needed at Kafka side, we may need to add shell commands likes SENTRY-399,SENTRY-995
- Dapeng Sun
On 二月 3, 2016, 3:12 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated 二月 3, 2016, 3:12 a.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 6, 2016, 4:51 a.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 72
> > <https://reviews.apache.org/r/43064/diff/4/?file=1235952#file1235952line72>
> >
> > Will the service name always be kafka? Thought it will be different based on which service instance it is actually coming from.
>
> Ashish Singh wrote:
> That is a valid concern. However, at this point I have no way of differentiating incoming requests based on source Kafka cluster. Only info we have is session, operation and resource for incoming authorize requests. In future, we might address this in future if the need be. However, for now we can just go ahead with assumption that we have just one Kafka cluster per Sentry instance.
Hao, I have filed SENTRY-1056.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118127
-----------------------------------------------------------
On Feb. 8, 2016, 8:16 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 8:16 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 6, 2016, 4:51 a.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 72
> > <https://reviews.apache.org/r/43064/diff/4/?file=1235952#file1235952line72>
> >
> > Will the service name always be kafka? Thought it will be different based on which service instance it is actually coming from.
That is a valid concern. However, at this point I have no way of differentiating incoming requests based on source Kafka cluster. Only info we have is session, operation and resource for incoming authorize requests. In future, we might address this in future if the need be. However, for now we can just go ahead with assumption that we have just one Kafka cluster per Sentry instance.
> On Feb. 6, 2016, 4:51 a.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 159
> > <https://reviews.apache.org/r/43064/diff/4/?file=1235952#file1235952line159>
> >
> > Rename to getAclsForAllRoles?
This is an overriden method, can't rename.
> On Feb. 6, 2016, 4:51 a.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java, line 178
> > <https://reviews.apache.org/r/43064/diff/4/?file=1235952#file1235952line178>
> >
> > Rename to getAclsForAllRoles?
This is an overriden method, can't rename.
> On Feb. 6, 2016, 4:51 a.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java, line 57
> > <https://reviews.apache.org/r/43064/diff/4/?file=1235953#file1235953line57>
> >
> > Remove?
Removed.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118127
-----------------------------------------------------------
On Feb. 5, 2016, 5:01 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 5:01 a.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118127
-----------------------------------------------------------
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java (line 72)
<https://reviews.apache.org/r/43064/#comment179370>
Will the service name always be kafka? Thought it will be different based on which service instance it is actually coming from.
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java (line 159)
<https://reviews.apache.org/r/43064/#comment179380>
Rename to getAclsForAllRoles?
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java (line 178)
<https://reviews.apache.org/r/43064/#comment179379>
Rename to getAclsForAllRoles?
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java (line 57)
<https://reviews.apache.org/r/43064/#comment179381>
Remove?
- Hao Hao
On Feb. 5, 2016, 5:01 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 5, 2016, 5:01 a.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118329
-----------------------------------------------------------
Ship it!
Only one more comment, otherwise LGTM +1.
- Hao Hao
On Feb. 8, 2016, 11:30 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 11:30 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
> On Feb. 8, 2016, 11:55 p.m., Hao Hao wrote:
> > sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java, line 41
> > <https://reviews.apache.org/r/43064/diff/6/?file=1237859#file1237859line41>
> >
> > I think this value also needs to be map with kafa server's property as Sentry-1056.
Hao, you are correct and this will be addressed in Sentry-1056.
- Ashish
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118326
-----------------------------------------------------------
On Feb. 8, 2016, 11:30 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 11:30 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Hao Hao <ha...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/#review118326
-----------------------------------------------------------
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java (line 41)
<https://reviews.apache.org/r/43064/#comment179554>
I think this value also needs to be map with kafa server's property as Sentry-1056.
- Hao Hao
On Feb. 8, 2016, 11:30 p.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43064/
> -----------------------------------------------------------
>
> (Updated Feb. 8, 2016, 11:30 p.m.)
>
>
> Review request for sentry and Dapeng Sun.
>
>
> Bugs: SENTRY-1011
> https://issues.apache.org/jira/browse/SENTRY-1011
>
>
> Repository: sentry
>
>
> Description
> -------
>
> SENTRY-1011: Add Kafka binding
>
>
> Diffs
> -----
>
> pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
> sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
> sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
> sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
> sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
>
> Diff: https://reviews.apache.org/r/43064/diff/
>
>
> Testing
> -------
>
> Tested with unit and e2e tests.
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 11:30 p.m.)
Review request for sentry and Dapeng Sun.
Changes
-------
Remove acls' CRUD implementations.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs (updated)
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
(Updated Feb. 8, 2016, 8:16 p.m.)
Review request for sentry and Dapeng Sun.
Changes
-------
Remove commented code.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs (updated)
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 5:01 a.m.)
Review request for sentry and Dapeng Sun.
Changes
-------
Remove commented code.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs (updated)
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
(Updated Feb. 5, 2016, 4:59 a.m.)
Review request for sentry and Dapeng Sun.
Changes
-------
Move dependency versions to project level pom.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs (updated)
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh
Re: Review Request 43064: SENTRY-1011: Add Kafka binding
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43064/
-----------------------------------------------------------
(Updated Feb. 2, 2016, 7:12 p.m.)
Review request for sentry and Dapeng Sun.
Changes
-------
Fix PMD error due to DCL.
Bugs: SENTRY-1011
https://issues.apache.org/jira/browse/SENTRY-1011
Repository: sentry
Description
-------
SENTRY-1011: Add Kafka binding
Diffs (updated)
-----
pom.xml aa99e313d8ae98bf048ce7d78574a9398f22732e
sentry-binding/pom.xml 0f2a987668cb3ea13d921636dfbc063bd17a3790
sentry-binding/sentry-binding-kafka/pom.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/ConvertUtil.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizer.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBinding.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/binding/KafkaAuthBindingSingleton.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/main/java/org/apache/sentry/kafka/conf/KafkaAuthConf.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/MockGroupMappingServiceProvider.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/ConvertUtilTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/java/org/apache/sentry/kafka/authorizer/SentryKafkaAuthorizerTest.java PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/core-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/log4j.properties PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/sentry-site.xml PRE-CREATION
sentry-binding/sentry-binding-kafka/src/test/resources/test-authz-provider.ini PRE-CREATION
sentry-provider/sentry-provider-common/src/main/java/org/apache/sentry/provider/common/AuthorizationComponent.java 6409015a92c94d37f21e0dbc8f7d7de74e3be5ec
Diff: https://reviews.apache.org/r/43064/diff/
Testing
-------
Tested with unit and e2e tests.
Thanks,
Ashish Singh