[GitHub] [hudi] nsivabalan commented on a diff in pull request #7336: [HUDI-5297] Deprecate InternalWriteStatus and re-use WriteStatus

["nsivabalan (via GitHub)" <gi...@apache.org>]

nsivabalan commented on code in PR #7336:
URL: https://github.com/apache/hudi/pull/7336#discussion_r1237765074


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/WriteStatus.java:
##########
@@ -52,9 +55,9 @@ public class WriteStatus implements Serializable {
 
   private final HashMap<HoodieKey, Throwable> errors = new HashMap<>();
 
-  private final List<HoodieRecord> writtenRecords = new ArrayList<>();
+  private final List<HoodieRecordDelegate> writtenRecordDelegates = new ArrayList<>();
 
-  private final List<HoodieRecord> failedRecords = new ArrayList<>();
+  private final List<Pair<HoodieRecordDelegate, Throwable>> failedRecords = new ArrayList<>();

Review Comment:
   we might need the original record for failed list. since we might want to log them. only for success, we don't need entire record. 
   btw, looks like we do deflate the content on success records. So, we can also consider leaving it as is. It was an oversight from my side. 
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org