[GitHub] [accumulo] EdColeman commented on a diff in pull request #2708: Disable Merging MINC by default

[GitBox <gi...@apache.org>]

EdColeman commented on code in PR #2708:
URL: https://github.com/apache/accumulo/pull/2708#discussion_r873771307


##########
core/src/main/java/org/apache/accumulo/core/conf/Property.java:
##########
@@ -683,10 +683,10 @@ public enum Property {
       "After a tablet has been idle (no mutations) for this time period it may have its "
           + "in-memory map flushed to disk in a minor compaction. There is no guarantee an idle "
           + "tablet will be compacted."),
-  TABLE_MINC_MAX_MERGE_FILE_SIZE("table.compaction.minor.merge.file.size.max", "0",
+  TABLE_MINC_MAX_MERGE_FILE_SIZE("table.compaction.minor.merge.file.size.max", "1",
       PropertyType.MEMORY,
-      "The max file size used for a merging minor compaction. The default value"
-          + " of 0 disables a max file size."),
+      "The max file size used for a merging minor compaction. The value of 0 is no max "
+          + "file size. The default value is 1 byte, which should disable merging minor compactions."),

Review Comment:
   Could / should this also say why merging compactions are disabled? This whole thing is confusing to me - not sure if it can be addressed here, or in the documentation (and maybe it is?) - but it seems that we have gone from always wanting to perform a merging compaction to never, but not explaining why.  And when disabled, the max files setting has increased importance because that's what is going to drive compactions (at least, I think that how it expected to work)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org