You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2021/07/29 19:35:38 UTC

[GitHub] [trafficcontrol] rimashah25 edited a comment on pull request #6067: Migrate Physical Location test from E2E to integrate test suite TP

rimashah25 edited a comment on pull request #6067:
URL: https://github.com/apache/trafficcontrol/pull/6067#issuecomment-889402386


   Incorrect expectation here: https://github.com/apache/trafficcontrol/blob/85e799993e78dadd3fd599815f15f597a6337a15/traffic_portal/test/integration/specs/PhysLocations.spec.ts#L47
   
   Should be `physical locations` instead of `parameters`
   
   
   Also, here: https://github.com/apache/trafficcontrol/blob/85e799993e78dadd3fd599815f15f597a6337a15/traffic_portal/test/integration/PageObjects/PhysLocationsPage.po.ts#L120, we should return only boolean. Read Brennan's explanation on why: https://github.com/apache/trafficcontrol/pull/5870#discussion_r635521989


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org